Uh oh!
There was an error while loading. Please reload this page.
tools: update doc tool dependencies - #36407
Closed
targos wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Dec 6, 2020
Collaborator
Trott
reviewed
Dec 7, 2020
Member
There was a problem hiding this comment.
I know these are listed as dev dependencies in the package.json, but they are used to generate our docs so a breaking change especially requires caution. When I do something like this, I make the docs with the packages in master and then make them with the packages in my branch and diff them.
Member
There was a problem hiding this comment.
(I'm doing this right now and will report what I find.)
Member
There was a problem hiding this comment.
Quick review shows lots of changes to code block rendering, but a spot check shows them to be either improvements or something that doesn't change anything I can detect visually. Here's the list of changes. If anyone's curious about any of them but doesn't want to build the docs themselves, I can post screenshots. (Building the docs is super easy and fast, though.)
Details
diff -r out/doc/api/all.html out/doc-old/api/all.html
4936c4936
---
5323c5323
< assert.deepStrictEqual(-<span class="hljs-number">0</span>, -<span class="hljs-number">0</span>);
---
> assert.deepStrictEqual(<span class="hljs-number">-0</span>, <span class="hljs-number">-0</span>);
5327c5327
< assert.deepStrictEqual(<span class="hljs-number">0</span>, -<span class="hljs-number">0</span>);
---
> assert.deepStrictEqual(<span class="hljs-number">0</span>, <span class="hljs-number">-0</span>);
6308,6309c6308,6309
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> { },
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> { }
---
> init(asyncId, type, triggerAsyncId, resource) { },
> destroy(asyncId) { }
6313,6314c6313,6314
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> { }
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> {}
---
> init(asyncId, type, triggerAsyncId, resource) { }
> destroy(asyncId) {}
6318,6319c6318,6319
< <span class="hljs-function"><span class="hljs-title">before</span>(<span class="hljs-params">asyncId</span>)</span> { }
< <span class="hljs-function"><span class="hljs-title">after</span>(<span class="hljs-params">asyncId</span>)</span> { }
---
> before(asyncId) { }
> after(asyncId) { }
6426c6426
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId</span>)</span> {
---
> init(asyncId, type, triggerAsyncId) {
6464c6464
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId</span>)</span> {
---
> init(asyncId, type, triggerAsyncId) {
6472c6472
< <span class="hljs-function"><span class="hljs-title">before</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> before(asyncId) {
6477c6477
< <span class="hljs-function"><span class="hljs-title">after</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> after(asyncId) {
6482c6482
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> destroy(asyncId) {
6622c6622
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> {
---
> init(asyncId, type, triggerAsyncId, resource) {
6709c6709
< ah.createHook({ <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params"></span>)</span> {} }).enable(); <span class="hljs-comment">// forces PromiseHooks to be enabled.</span>
---
> ah.createHook({ init() {} }).enable(); <span class="hljs-comment">// forces PromiseHooks to be enabled.</span>
6780c6780
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">db</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(db) {
6785c6785
< <span class="hljs-function"><span class="hljs-title">getInfo</span>(<span class="hljs-params">query, callback</span>)</span> {
---
> getInfo(query, callback) {
6791c6791
< <span class="hljs-function"><span class="hljs-title">close</span>(<span class="hljs-params"></span>)</span> {
---
> close() {
6870c6870
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">callback</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(callback) {
6875c6875
< <span class="hljs-function"><span class="hljs-title">done</span>(<span class="hljs-params">err, result</span>)</span> {
---
> done(err, result) {
6882c6882
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">numThreads</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(numThreads) {
6892c6892
< <span class="hljs-function"><span class="hljs-title">addNewWorker</span>(<span class="hljs-params"></span>)</span> {
---
> addNewWorker() {
6920c6920
< <span class="hljs-function"><span class="hljs-title">runTask</span>(<span class="hljs-params">task, callback</span>)</span> {
---
> runTask(task, callback) {
6932c6932
< <span class="hljs-function"><span class="hljs-title">close</span>(<span class="hljs-params"></span>)</span> {
---
> close() {
7190c7190
< <span class="hljs-keyword">const</span> buf5 = Buffer.from([<span class="hljs-number">257</span>, <span class="hljs-number">257.5</span>, -<span class="hljs-number">255</span>, <span class="hljs-string">'1'</span>]);
---
> <span class="hljs-keyword">const</span> buf5 = Buffer.from([<span class="hljs-number">257</span>, <span class="hljs-number">257.5</span>, <span class="hljs-number">-255</span>, <span class="hljs-string">'1'</span>]);
8201c8201
< <span class="hljs-built_in">console</span>.log(utf16Buffer.indexOf(<span class="hljs-string">'\u03a3'</span>, -<span class="hljs-number">4</span>, <span class="hljs-string">'utf16le'</span>));
---
> <span class="hljs-built_in">console</span>.log(utf16Buffer.indexOf(<span class="hljs-string">'\u03a3'</span>, <span class="hljs-number">-4</span>, <span class="hljs-string">'utf16le'</span>));
8291c8291
< <span class="hljs-built_in">console</span>.log(utf16Buffer.lastIndexOf(<span class="hljs-string">'\u03a3'</span>, -<span class="hljs-number">5</span>, <span class="hljs-string">'utf16le'</span>));
---
> <span class="hljs-built_in">console</span>.log(utf16Buffer.lastIndexOf(<span class="hljs-string">'\u03a3'</span>, <span class="hljs-number">-5</span>, <span class="hljs-string">'utf16le'</span>));
8523c8523
< <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([-<span class="hljs-number">1</span>, <span class="hljs-number">5</span>]);
---
> <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">-1</span>, <span class="hljs-number">5</span>]);
8705c8705
< <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">1</span>, -<span class="hljs-number">2</span>]);
---
> <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">1</span>, <span class="hljs-number">-2</span>]);
8919c8919
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">6</span>, -<span class="hljs-number">1</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-6</span>, <span class="hljs-number">-1</span>).toString());
8923c8923
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">6</span>, -<span class="hljs-number">2</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-6</span>, <span class="hljs-number">-2</span>).toString());
8927c8927
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">5</span>, -<span class="hljs-number">2</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-5</span>, <span class="hljs-number">-2</span>).toString());
9382c9382
< buf.writeInt8(-<span class="hljs-number">2</span>, <span class="hljs-number">1</span>);
---
> buf.writeInt8(<span class="hljs-number">-2</span>, <span class="hljs-number">1</span>);
11666c11666
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
11744c11744
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
11756c11756
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
12729c12729
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
12743c12743
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
12757c12757
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
12765c12765
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
12785c12785
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
14159c14159
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
28400c28400
< <pre><code class="language-js"><span class="hljs-built_in">require</span>(<span class="hljs-string">'net'</span>).connect(-<span class="hljs-number">1</span>);
---
> <pre><code class="language-js"><span class="hljs-built_in">require</span>(<span class="hljs-string">'net'</span>).connect(<span class="hljs-number">-1</span>);
30653c30653
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params"></span>)</span> {
---
> <span class="hljs-keyword">constructor</span>() {
30662c30662
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">err</span>)</span> {
---
> destroy(err) {
31055c31055
< <span class="hljs-function"><span class="hljs-title">handleEvent</span>(<span class="hljs-params">event</span>)</span> {
---
> handleEvent(event) {
31061c31061
< <span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-title">handleEvent</span>(<span class="hljs-params">event</span>)</span> {
---
> <span class="hljs-keyword">async</span> handleEvent(event) {
31518c31518
< (<span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params"><span class="hljs-keyword">from</span>, to</span>) </span>{
---
> (<span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params">from, to</span>) </span>{
41906c41906
< is 0. The maximum allowed value is 22<sup>32</sup>-1. A negative value sets
---
> is 0. The maximum allowed value is 2<sup>32</sup>-1. A negative value sets
42171c42171
< is 22<sup>32</sup>-1. <strong>Default:</strong> <code>4096</code>.</li>
---
> is 2<sup>32</sup>-1. <strong>Default:</strong> <code>4096</code>.</li>
42179c42179
< 22<sup>24</sup>-1. <strong>Default:</strong> <code>16384</code>.</li>
---
> 2<sup>24</sup>-1. <strong>Default:</strong> <code>16384</code>.</li>
42188c42188
< maximum allowed value is 22<sup>32</sup>-1. <strong>Default:</strong> <code>65535</code>.</li>
---
> maximum allowed value is 2<sup>32</sup>-1. <strong>Default:</strong> <code>65535</code>.</li>
43916c43916
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">width</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(width) {
43920c43920
< <span class="hljs-function"><span class="hljs-title">area</span>(<span class="hljs-params"></span>)</span> {
---
> area() {
44257c44257
< <pre><code class="language-js">(<span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params"><span class="hljs-built_in">exports</span>, <span class="hljs-built_in">require</span>, <span class="hljs-built_in">module</span>, __filename, __dirname</span>) </span>{
---
> <pre><code class="language-js">(<span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params">exports, require, module, __filename, __dirname</span>) </span>{
44539c44539
< <pre><code class="language-js"><span class="hljs-function"><span class="hljs-keyword">function</span> <span class="hljs-title">require</span>(<span class="hljs-params"><span class="hljs-comment">/* ... */</span></span>) </span>{
---
> <pre><code class="language-js"><span class="hljs-function"><span class="hljs-keyword">function</span> <span class="hljs-title">require</span>(<span class="hljs-params"><span class="hljs-regexp">/* ... */</span></span>) </span>{
50339c50339
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">id, type</span>)</span> {
---
> init(id, type) {
50345c50345
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">id</span>)</span> {
---
> destroy(id) {
55290c55290
< <span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-title">clientHelloHandler</span>(<span class="hljs-params">alpn, servername, ciphers</span>)</span> {
---
> <span class="hljs-keyword">async</span> clientHelloHandler(alpn, servername, ciphers) {
56403c56403
< <span class="hljs-function"><span class="hljs-title">action</span>(<span class="hljs-params">name</span>)</span> {
---
> action(name) {
57197c57197
---
58760c58760
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">{ highWaterMark, ...options }</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>({ highWaterMark, ...options }) {
58825c58825
< <span class="hljs-function"><span class="hljs-title">construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> construct(callback) {
58828c58828
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
58831c58831
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params"></span>)</span> {
---
> destroy() {
58895c58895
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
58915c58915
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
58918c58918
< <span class="hljs-function"><span class="hljs-title">writev</span>(<span class="hljs-params">chunks, callback</span>)</span> {
---
> writev(chunks, callback) {
58941c58941
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">filename</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(filename) {
58946c58946
< <span class="hljs-function"><span class="hljs-title">_construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> _construct(callback) {
58956c58956
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
58959c58959
< <span class="hljs-function"><span class="hljs-title">_destroy</span>(<span class="hljs-params">err, callback</span>)</span> {
---
> _destroy(err, callback) {
59070c59070
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
59086c59086
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
59103c59103
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
59108c59108
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
59115c59115
< <span class="hljs-function"><span class="hljs-title">_final</span>(<span class="hljs-params">callback</span>)</span> {
---
> _final(callback) {
59173c59173
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
59193c59193
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
59216c59216
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">filename</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(filename) {
59221c59221
< <span class="hljs-function"><span class="hljs-title">_construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> _construct(callback) {
59231c59231
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">n</span>)</span> {
---
> _read(n) {
59241c59241
< <span class="hljs-function"><span class="hljs-title">_destroy</span>(<span class="hljs-params">err, callback</span>)</span> {
---
> _destroy(err, callback) {
59329c59329
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
59348c59348
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">size</span>)</span> {
---
> _read(size) {
59365c59365
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
59381c59381
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">opt</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(opt) {
59387c59387
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params"></span>)</span> {
---
> _read() {
59447c59447
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
59466c59466
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
59469c59469
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
59482c59482
< <span class="hljs-function"><span class="hljs-title">construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> construct(callback) {
59486c59486
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
59490c59490
< <span class="hljs-function"><span class="hljs-title">flush</span>(<span class="hljs-params">callback</span>)</span> {
---
> flush(callback) {
59521c59521
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">source, options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(source, options) {
59526c59526
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
59534c59534
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">size</span>)</span> {
---
> _read(size) {
59557c59557
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
59612c59612
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
59631c59631
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
64529c64529
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">data</span>)</span> {
---
> write(data) {
64863c64863
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">value</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(value) {
64921c64921
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">value</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(value) {
64925c64925
< <span class="hljs-function"><span class="hljs-title">toString</span>(<span class="hljs-params"></span>)</span> {
---
> toString() {
65008c65008
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params"></span>)</span> {
---
> <span class="hljs-keyword">constructor</span>() {
65012c65012
< <span class="hljs-function"><span class="hljs-title">bar</span>(<span class="hljs-params">callback</span>)</span> {
---
> bar(callback) {
67406c67406
< <span class="hljs-function"><span class="hljs-title">initializeImportMeta</span>(<span class="hljs-params">meta</span>)</span> {
---
> initializeImportMeta(meta) {
diff -r out/doc/api/assert.html out/doc-old/api/assert.html
251c251
---
638c638
< assert.deepStrictEqual(-<span class="hljs-number">0</span>, -<span class="hljs-number">0</span>);
---
> assert.deepStrictEqual(<span class="hljs-number">-0</span>, <span class="hljs-number">-0</span>);
642c642
< assert.deepStrictEqual(<span class="hljs-number">0</span>, -<span class="hljs-number">0</span>);
---
> assert.deepStrictEqual(<span class="hljs-number">0</span>, <span class="hljs-number">-0</span>);
diff -r out/doc/api/async_hooks.html out/doc-old/api/async_hooks.html
295,296c295,296
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> { },
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> { }
---
> init(asyncId, type, triggerAsyncId, resource) { },
> destroy(asyncId) { }
300,301c300,301
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> { }
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> {}
---
> init(asyncId, type, triggerAsyncId, resource) { }
> destroy(asyncId) {}
305,306c305,306
< <span class="hljs-function"><span class="hljs-title">before</span>(<span class="hljs-params">asyncId</span>)</span> { }
< <span class="hljs-function"><span class="hljs-title">after</span>(<span class="hljs-params">asyncId</span>)</span> { }
---
> before(asyncId) { }
> after(asyncId) { }
413c413
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId</span>)</span> {
---
> init(asyncId, type, triggerAsyncId) {
451c451
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId</span>)</span> {
---
> init(asyncId, type, triggerAsyncId) {
459c459
< <span class="hljs-function"><span class="hljs-title">before</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> before(asyncId) {
464c464
< <span class="hljs-function"><span class="hljs-title">after</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> after(asyncId) {
469c469
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">asyncId</span>)</span> {
---
> destroy(asyncId) {
609c609
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">asyncId, type, triggerAsyncId, resource</span>)</span> {
---
> init(asyncId, type, triggerAsyncId, resource) {
696c696
< ah.createHook({ <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params"></span>)</span> {} }).enable(); <span class="hljs-comment">// forces PromiseHooks to be enabled.</span>
---
> ah.createHook({ init() {} }).enable(); <span class="hljs-comment">// forces PromiseHooks to be enabled.</span>
767c767
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">db</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(db) {
772c772
< <span class="hljs-function"><span class="hljs-title">getInfo</span>(<span class="hljs-params">query, callback</span>)</span> {
---
> getInfo(query, callback) {
778c778
< <span class="hljs-function"><span class="hljs-title">close</span>(<span class="hljs-params"></span>)</span> {
---
> close() {
857c857
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">callback</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(callback) {
862c862
< <span class="hljs-function"><span class="hljs-title">done</span>(<span class="hljs-params">err, result</span>)</span> {
---
> done(err, result) {
869c869
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">numThreads</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(numThreads) {
879c879
< <span class="hljs-function"><span class="hljs-title">addNewWorker</span>(<span class="hljs-params"></span>)</span> {
---
> addNewWorker() {
907c907
< <span class="hljs-function"><span class="hljs-title">runTask</span>(<span class="hljs-params">task, callback</span>)</span> {
---
> runTask(task, callback) {
919c919
< <span class="hljs-function"><span class="hljs-title">close</span>(<span class="hljs-params"></span>)</span> {
---
> close() {
diff -r out/doc/api/buffer.html out/doc-old/api/buffer.html
287c287
< <span class="hljs-keyword">const</span> buf5 = Buffer.from([<span class="hljs-number">257</span>, <span class="hljs-number">257.5</span>, -<span class="hljs-number">255</span>, <span class="hljs-string">'1'</span>]);
---
> <span class="hljs-keyword">const</span> buf5 = Buffer.from([<span class="hljs-number">257</span>, <span class="hljs-number">257.5</span>, <span class="hljs-number">-255</span>, <span class="hljs-string">'1'</span>]);
1298c1298
< <span class="hljs-built_in">console</span>.log(utf16Buffer.indexOf(<span class="hljs-string">'\u03a3'</span>, -<span class="hljs-number">4</span>, <span class="hljs-string">'utf16le'</span>));
---
> <span class="hljs-built_in">console</span>.log(utf16Buffer.indexOf(<span class="hljs-string">'\u03a3'</span>, <span class="hljs-number">-4</span>, <span class="hljs-string">'utf16le'</span>));
1388c1388
< <span class="hljs-built_in">console</span>.log(utf16Buffer.lastIndexOf(<span class="hljs-string">'\u03a3'</span>, -<span class="hljs-number">5</span>, <span class="hljs-string">'utf16le'</span>));
---
> <span class="hljs-built_in">console</span>.log(utf16Buffer.lastIndexOf(<span class="hljs-string">'\u03a3'</span>, <span class="hljs-number">-5</span>, <span class="hljs-string">'utf16le'</span>));
1620c1620
< <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([-<span class="hljs-number">1</span>, <span class="hljs-number">5</span>]);
---
> <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">-1</span>, <span class="hljs-number">5</span>]);
1802c1802
< <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">1</span>, -<span class="hljs-number">2</span>]);
---
> <pre><code class="language-js"><span class="hljs-keyword">const</span> buf = Buffer.from([<span class="hljs-number">1</span>, <span class="hljs-number">-2</span>]);
2016c2016
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">6</span>, -<span class="hljs-number">1</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-6</span>, <span class="hljs-number">-1</span>).toString());
2020c2020
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">6</span>, -<span class="hljs-number">2</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-6</span>, <span class="hljs-number">-2</span>).toString());
2024c2024
< <span class="hljs-built_in">console</span>.log(buf.subarray(-<span class="hljs-number">5</span>, -<span class="hljs-number">2</span>).toString());
---
> <span class="hljs-built_in">console</span>.log(buf.subarray(<span class="hljs-number">-5</span>, <span class="hljs-number">-2</span>).toString());
2479c2479
< buf.writeInt8(-<span class="hljs-number">2</span>, <span class="hljs-number">1</span>);
---
> buf.writeInt8(<span class="hljs-number">-2</span>, <span class="hljs-number">1</span>);
diff -r out/doc/api/errors.html out/doc-old/api/errors.html
805c805
< <pre><code class="language-js"><span class="hljs-built_in">require</span>(<span class="hljs-string">'net'</span>).connect(-<span class="hljs-number">1</span>);
---
> <pre><code class="language-js"><span class="hljs-built_in">require</span>(<span class="hljs-string">'net'</span>).connect(<span class="hljs-number">-1</span>);
diff -r out/doc/api/events.html out/doc-old/api/events.html
823c823
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params"></span>)</span> {
---
> <span class="hljs-keyword">constructor</span>() {
832c832
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">err</span>)</span> {
---
> destroy(err) {
1225c1225
< <span class="hljs-function"><span class="hljs-title">handleEvent</span>(<span class="hljs-params">event</span>)</span> {
---
> handleEvent(event) {
1231c1231
< <span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-title">handleEvent</span>(<span class="hljs-params">event</span>)</span> {
---
> <span class="hljs-keyword">async</span> handleEvent(event) {
diff -r out/doc/api/fs.html out/doc-old/api/fs.html
496c496
< (<span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params"><span class="hljs-keyword">from</span>, to</span>) </span>{
---
> (<span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params">from, to</span>) </span>{
diff -r out/doc/api/http2.html out/doc-old/api/http2.html
2484c2484
< is 0. The maximum allowed value is 22<sup>32</sup>-1. A negative value sets
---
> is 0. The maximum allowed value is 2<sup>32</sup>-1. A negative value sets
2749c2749
< is 22<sup>32</sup>-1. <strong>Default:</strong> <code>4096</code>.</li>
---
> is 2<sup>32</sup>-1. <strong>Default:</strong> <code>4096</code>.</li>
2757c2757
< 22<sup>24</sup>-1. <strong>Default:</strong> <code>16384</code>.</li>
---
> 2<sup>24</sup>-1. <strong>Default:</strong> <code>16384</code>.</li>
2766c2766
< maximum allowed value is 22<sup>32</sup>-1. <strong>Default:</strong> <code>65535</code>.</li>
---
> maximum allowed value is 2<sup>32</sup>-1. <strong>Default:</strong> <code>65535</code>.</li>
diff -r out/doc/api/modules.html out/doc-old/api/modules.html
226c226
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">width</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(width) {
230c230
< <span class="hljs-function"><span class="hljs-title">area</span>(<span class="hljs-params"></span>)</span> {
---
> area() {
567c567
< <pre><code class="language-js">(<span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params"><span class="hljs-built_in">exports</span>, <span class="hljs-built_in">require</span>, <span class="hljs-built_in">module</span>, __filename, __dirname</span>) </span>{
---
> <pre><code class="language-js">(<span class="hljs-function"><span class="hljs-keyword">function</span>(<span class="hljs-params">exports, require, module, __filename, __dirname</span>) </span>{
849c849
< <pre><code class="language-js"><span class="hljs-function"><span class="hljs-keyword">function</span> <span class="hljs-title">require</span>(<span class="hljs-params"><span class="hljs-comment">/* ... */</span></span>) </span>{
---
> <pre><code class="language-js"><span class="hljs-function"><span class="hljs-keyword">function</span> <span class="hljs-title">require</span>(<span class="hljs-params"><span class="hljs-regexp">/* ... */</span></span>) </span>{
diff -r out/doc/api/n-api.html out/doc-old/api/n-api.html
874c874
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
952c952
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
964c964
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
1937c1937
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
1951c1951
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
1965c1965
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
1973c1973
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
1993c1993
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
3367c3367
< <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-class"><span class="hljs-keyword">enum</span> {</span>
---
> <pre><code class="language-c"><span class="hljs-keyword">typedef</span> <span class="hljs-keyword">enum</span> {
diff -r out/doc/api/perf_hooks.html out/doc-old/api/perf_hooks.html
825c825
< <span class="hljs-function"><span class="hljs-title">init</span>(<span class="hljs-params">id, type</span>)</span> {
---
> init(id, type) {
831c831
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params">id</span>)</span> {
---
> destroy(id) {
diff -r out/doc/api/quic.html out/doc-old/api/quic.html
2581c2581
< <span class="hljs-keyword">async</span> <span class="hljs-function"><span class="hljs-title">clientHelloHandler</span>(<span class="hljs-params">alpn, servername, ciphers</span>)</span> {
---
> <span class="hljs-keyword">async</span> clientHelloHandler(alpn, servername, ciphers) {
diff -r out/doc/api/repl.html out/doc-old/api/repl.html
540c540
< <span class="hljs-function"><span class="hljs-title">action</span>(<span class="hljs-params">name</span>)</span> {
---
> action(name) {
diff -r out/doc/api/stream.html out/doc-old/api/stream.html
293c293
---
1856c1856
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">{ highWaterMark, ...options }</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>({ highWaterMark, ...options }) {
1921c1921
< <span class="hljs-function"><span class="hljs-title">construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> construct(callback) {
1924c1924
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
1927c1927
< <span class="hljs-function"><span class="hljs-title">destroy</span>(<span class="hljs-params"></span>)</span> {
---
> destroy() {
1991c1991
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2011c2011
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
2014c2014
< <span class="hljs-function"><span class="hljs-title">writev</span>(<span class="hljs-params">chunks, callback</span>)</span> {
---
> writev(chunks, callback) {
2037c2037
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">filename</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(filename) {
2042c2042
< <span class="hljs-function"><span class="hljs-title">_construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> _construct(callback) {
2052c2052
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
2055c2055
< <span class="hljs-function"><span class="hljs-title">_destroy</span>(<span class="hljs-params">err, callback</span>)</span> {
---
> _destroy(err, callback) {
2166c2166
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
2182c2182
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
2199c2199
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2204c2204
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
2211c2211
< <span class="hljs-function"><span class="hljs-title">_final</span>(<span class="hljs-params">callback</span>)</span> {
---
> _final(callback) {
2269c2269
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2289c2289
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
2312c2312
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">filename</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(filename) {
2317c2317
< <span class="hljs-function"><span class="hljs-title">_construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> _construct(callback) {
2327c2327
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">n</span>)</span> {
---
> _read(n) {
2337c2337
< <span class="hljs-function"><span class="hljs-title">_destroy</span>(<span class="hljs-params">err, callback</span>)</span> {
---
> _destroy(err, callback) {
2425c2425
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2444c2444
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">size</span>)</span> {
---
> _read(size) {
2461c2461
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
2477c2477
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">opt</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(opt) {
2483c2483
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params"></span>)</span> {
---
> _read() {
2543c2543
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2562c2562
< <span class="hljs-function"><span class="hljs-title">read</span>(<span class="hljs-params">size</span>)</span> {
---
> read(size) {
2565c2565
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> write(chunk, encoding, callback) {
2578c2578
< <span class="hljs-function"><span class="hljs-title">construct</span>(<span class="hljs-params">callback</span>)</span> {
---
> construct(callback) {
2582c2582
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
2586c2586
< <span class="hljs-function"><span class="hljs-title">flush</span>(<span class="hljs-params">callback</span>)</span> {
---
> flush(callback) {
2617c2617
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">source, options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(source, options) {
2622c2622
< <span class="hljs-function"><span class="hljs-title">_write</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> _write(chunk, encoding, callback) {
2630c2630
< <span class="hljs-function"><span class="hljs-title">_read</span>(<span class="hljs-params">size</span>)</span> {
---
> _read(size) {
2653c2653
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
2708c2708
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">options</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(options) {
2727c2727
< <span class="hljs-function"><span class="hljs-title">transform</span>(<span class="hljs-params">chunk, encoding, callback</span>)</span> {
---
> transform(chunk, encoding, callback) {
diff -r out/doc/api/util.html out/doc-old/api/util.html
594c594
< <span class="hljs-function"><span class="hljs-title">write</span>(<span class="hljs-params">data</span>)</span> {
---
> write(data) {
928c928
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">value</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(value) {
986c986
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params">value</span>)</span> {
---
> <span class="hljs-keyword">constructor</span>(value) {
990c990
< <span class="hljs-function"><span class="hljs-title">toString</span>(<span class="hljs-params"></span>)</span> {
---
> toString() {
1073c1073
< <span class="hljs-function"><span class="hljs-title">constructor</span>(<span class="hljs-params"></span>)</span> {
---
> <span class="hljs-keyword">constructor</span>() {
1077c1077
< <span class="hljs-function"><span class="hljs-title">bar</span>(<span class="hljs-params">callback</span>)</span> {
---
> bar(callback) {
diff -r out/doc/api/vm.html out/doc-old/api/vm.html
843c843
< <span class="hljs-function"><span class="hljs-title">initializeImportMeta</span>(<span class="hljs-params">meta</span>)</span> {
---
> initializeImportMeta(meta) {
diff -r out/doc/apilinks.json out/doc-old/apilinks.json
2,519c2,519
---
Member
There was a problem hiding this comment.
Sample improvement: The assert docs now highlight -0 as a number instead of highlighting only 0 and leaving the - un-highlighted:
Before:
After:
Member
There was a problem hiding this comment.
Sample "I don't see any difference despite the underlying code changing": The vm module has this line changed but I don't see any difference.
Before:
After:
(Alignment change is due to the imprecision of my screenshot placement. They are identical.)
Trott
approved these changes
Dec 7, 2020
targos
commented
Dec 7, 2020
MemberAuthor
Thanks for double checking @Trott . I should have been more transparent and said that I did exactly what you did |
nodejs-github-bot
commented
Dec 7, 2020
Collaborator
nodejs-github-bot
commented
Dec 8, 2020
Collaborator
jasnell
approved these changes
Dec 8, 2020
Contributor
Landed in e31a99f...8dbeac6 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #36407 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36407 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36407 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes