Uh oh!
There was an error while loading. Please reload this page.
tools: update ESLint to 7.15.0 - #36411
Closed
cjihrig wants to merge 2 commits into
Closed
Conversation
Trott
approved these changes
Dec 6, 2020
targos
approved these changes
Dec 6, 2020
lpinca
approved these changes
Dec 6, 2020
Update ESLint to 7.15.0
This rule is new in ESLint 7.15.0.
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36411 ✔ Done loading data for nodejs/node/pull/36411 ----------------------------------- PR info ------------------------------------ Title tools: update ESLint to 7.15.0 (#36411) Author Colin Ihrig (@cjihrig) Branch cjihrig:eslint -> nodejs:master Labels tools Commits 2 - tools: update ESLint to 7.15.0 - tools: enable no-unsafe-optional-chaining lint rule Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/36411 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36411 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected ℹ This PR was created on Sun, 06 Dec 2020 15:19:00 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/408627427 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36411 ✔ Done loading data for nodejs/node/pull/36411 ----------------------------------- PR info ------------------------------------ Title tools: update ESLint to 7.15.0 (#36411) Author Colin Ihrig (@cjihrig) Branch cjihrig:eslint -> nodejs:master Labels author ready, tools Commits 2 - tools: update ESLint to 7.15.0 - tools: enable no-unsafe-optional-chaining lint rule Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/36411 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36411 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-08T17:36:33Z: https://ci.nodejs.org/job/node-test-pull-request/34850/ - Querying data for job/node-test-pull-request/34850/ ✔ Build data downloaded - Querying failures of job/node-test-commit/42841/ ✔ Data downloaded ✖ 3 failure(s) on the last Jenkins CI run ℹ This PR was created on Sun, 06 Dec 2020 15:19:00 GMT ✔ Approvals: 4 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545715844 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/36411#pullrequestreview-545716126 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/36411#pullrequestreview-545745988 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/36411#pullrequestreview-547380421 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/408983371 |
nodejs-github-bot
commented
Dec 8, 2020
Collaborator
jasnell
approved these changes
Dec 8, 2020
watilde
approved these changes
Dec 8, 2020
nodejs-github-bot
commented
Dec 9, 2020
Collaborator
Contributor
Landed in 27a63ee...a26ae70 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 9, 2020
Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 9, 2020
This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
May 16, 2021
Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
May 16, 2021
This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
Update ESLint to 7.15.0 PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
This rule is new in ESLint 7.15.0. PR-URL: #36411 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint to 7.15.0 and enable the new
no-unsafe-optional-chainingrule.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes