Uh oh!
There was an error while loading. Please reload this page.
src: guard against env != null in node_errors.cc - #36414
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Otherwise `TriggerUncaughtException()` → `PrintException()` → `GetErrorSource()` can crash.
addaleaxforce-pushed
the
source-maps-env
branch
from
December 6, 2020 15:42
c40b5ce to
f3a7f81Comparenodejs-github-bot
commented
Dec 6, 2020
Collaborator
targos
approved these changes
Dec 6, 2020
cjihrig
approved these changes
Dec 6, 2020
benjamingr
approved these changes
Dec 6, 2020
lpinca
approved these changes
Dec 6, 2020
nodejs-github-bot
commented
Dec 7, 2020
Collaborator
nodejs-github-bot
commented
Dec 8, 2020
Collaborator
jasnell
approved these changes
Dec 8, 2020
nodejs-github-bot
commented
Dec 8, 2020
Collaborator
codebytere
approved these changes
Dec 9, 2020
Trott
approved these changes
Dec 11, 2020
nodejs-github-bot
commented
Dec 11, 2020
Collaborator
Contributor
Landed in 88dfecc...7069d22 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 13, 2020
Otherwise `TriggerUncaughtException()` → `PrintException()` → `GetErrorSource()` can crash. PR-URL: #36414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
Otherwise `TriggerUncaughtException()` → `PrintException()` → `GetErrorSource()` can crash. PR-URL: #36414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
Otherwise `TriggerUncaughtException()` → `PrintException()` → `GetErrorSource()` can crash. PR-URL: #36414 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise
TriggerUncaughtException()→
PrintException()→
GetErrorSource()can crash.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes