Uh oh!
There was an error while loading. Please reload this page.
child_process: add signal support to spawn - #36432
Closed
benjamingr wants to merge 1 commit into
Closed
Conversation
benjamingrforce-pushed
the
add-signal-to-child-process-spawn
branch
from
December 7, 2020 17:12
d9e78c3 to
40b97afComparebenjamingr
commented
Dec 7, 2020
MemberAuthor
There was a problem hiding this comment.
This is an unrelated fix I noticed when reading the docs.
benjamingrforce-pushed
the
add-signal-to-child-process-spawn
branch
from
December 7, 2020 23:29
40b97af to
ff4492eComparetargos
reviewed
Dec 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
benjamingrforce-pushed
the
add-signal-to-child-process-spawn
branch
from
December 8, 2020 18:48
ff4492e to
8f3cf59Comparejasnell
approved these changes
Dec 8, 2020
nodejs-github-bot
commented
Dec 10, 2020
Collaborator
Trott
approved these changes
Dec 12, 2020
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/36432 ✔ Done loading data for nodejs/node/pull/36432 ----------------------------------- PR info ------------------------------------ Title child_process: add signal support to spawn (#36432) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch benjamingr:add-signal-to-child-process-spawn -> nodejs:master Labels child_process, semver-minor Commits 1 - child_process: add signal support to spawn Committers 1 - Benjamin Gruenbaum PR-URL: https://github.com/nodejs/node/pull/36432 Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36432 Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-12-10T19:07:23Z: https://ci.nodejs.org/job/node-test-pull-request/34890/ - Querying data for job/node-test-pull-request/34890/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Mon, 07 Dec 2020 17:11:17 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/36432#pullrequestreview-547674438 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36432#pullrequestreview-550835437 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/417481139 |
Contributor
Landed in d50b2ff...738cd60 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 12, 2020
PR-URL: #36432 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #36432 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit
that referenced
this pull request
Dec 22, 2020
Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432 doc: * add PoojaDurgad to collaborators (Pooja D P) #36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431 PR-URL: #36597
targos added a commit
that referenced
this pull request
Dec 22, 2020
Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432 doc: * add PoojaDurgad to collaborators (Pooja D P) #36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431 PR-URL: #36597
targos added a commit
that referenced
this pull request
Dec 22, 2020
Notable changes: child_process: * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432 doc: * add PoojaDurgad to collaborators (Pooja D P) #36511 lib: * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499 src: * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447 stream: * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431 PR-URL: #36597
targos pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#36432 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next one in the "add AbortSignal to the child_process APIs"
I initially tried to make this generic and use a strategy pattern in the spawn implementation but after playing with it it was much harder to verify so I duplicated the specific code and I think it's more readable/obvious now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes