Uh oh!
There was an error while loading. Please reload this page.
doc: add issue reference to github pr template - #36440
Closed
chinmoy12c wants to merge 1 commit into
Closed
Conversation
aduh95
reviewed
Dec 8, 2020
aduh95
left a comment
Contributor
There was a problem hiding this comment.
We expect the full URL in the commit message, I think the PR template should be aligned (GitHub UI will show only the issue number anyway).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
chinmoy12c
commented
Dec 8, 2020
ContributorAuthor
Thanks for the review, made the changes. :) |
jasnell
reviewed
Dec 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
jasnell
reviewed
Dec 8, 2020
Uh oh!
There was an error while loading. Please reload this page.
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: nodejs#36338
jasnell
approved these changes
Dec 16, 2020
jasnell pushed a commit
that referenced
this pull request
Dec 16, 2020
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: #36338 PR-URL: #36440 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 16, 2020
Member
Landed in 4a6200e |
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: #36338 PR-URL: #36440 Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
The PR template should include a Reference isssue (Fixes #issue_number) so the PR can be tracked back to the issue easily.For a beginner trying to read PRs to become comfortable with the codebase,it is really helpful if one can directly reach the issue the PR fixes. Fixes: #36338 PR-URL: #36440 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.
Fixes: #36338
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes