Uh oh!
There was an error while loading. Please reload this page.
lib: refactor to use more primordials in internal/encoding.js - #36480
Closed
RaisinTen wants to merge 1 commit into
Closed
lib: refactor to use more primordials in internal/encoding.js#36480RaisinTen wants to merge 1 commit into
RaisinTen wants to merge 1 commit into
Conversation
targos
approved these changes
Dec 11, 2020
RaisinTenforce-pushed
the
lib/refactor-to-use-more-primordials-in-internal/encoding.js
branch
from
December 11, 2020 17:23
33c364d to
36f8579CompareRaisinTen
marked this pull request as ready for review
December 11, 2020 17:24
Trott
approved these changes
Dec 13, 2020
Trott
commented
Dec 13, 2020
Member
Should any benchmarks be run on this before landing? This file gets used in |
nodejs-github-bot
commented
Dec 13, 2020
Collaborator
PoojaDurgad
approved these changes
Dec 18, 2020
aduh95
approved these changes
Dec 22, 2020
aduh95
commented
Dec 22, 2020
Contributor
aduh95
commented
Dec 26, 2020
Contributor
Another benchmark CI to be sure there's no regression: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/806/ (queued, will 404 until it starts) |
aduh95
approved these changes
Dec 26, 2020
aduh95
left a comment
Contributor
There was a problem hiding this comment.
No regression found in the benchmark
Contributor
Landed in 9df3b76...c4cbdfa |
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 26, 2020
PR-URL: #36480 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RaisinTen
deleted the
lib/refactor-to-use-more-primordials-in-internal/encoding.js
branch
December 27, 2020 06:39
danielleadams pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36480 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36480 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36480 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36480 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes