Skip to content

test: remove test-http2-client-upload as flaky - #36496

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:flaky-removal
Dec 15, 2020
Merged

test: remove test-http2-client-upload as flaky#36496
Trott merged 1 commit into
nodejs:masterfrom
Trott:flaky-removal

Conversation

@Trott

@TrottTrott commented Dec 12, 2020

Copy link
Copy Markdown
Member

The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: #29889

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 12, 2020
@targostargos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 13, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34920/

@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34931/

@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34934/

@Trott
test: remove test-http2-client-upload as flaky
7c80817
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.
Refs: nodejs#29889
PR-URL: nodejs#36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Trott commented Dec 15, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 7c80817

@Trott
Trott merged commit 7c80817 into nodejs:masterDec 15, 2020
@Trott
Trott deleted the flaky-removal branch December 15, 2020 11:41
targos pushed a commit that referenced this pull request Dec 21, 2020
@Trott@targos
test: remove test-http2-client-upload as flaky
9f2d3c2
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.
Refs: #29889
PR-URL: #36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott@targos
test: remove test-http2-client-upload as flaky
c0604c9
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.
Refs: #29889
PR-URL: #36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@lpinca@targos@Flarna