Skip to content

tools: remove unused variable in configure.py - #36525

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:write-config
Dec 17, 2020
Merged

tools: remove unused variable in configure.py#36525
Trott merged 0 commit into
nodejs:masterfrom
Trott:write-config

Conversation

@Trott

@TrottTrott commented Dec 15, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Dec 15, 2020
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34948/

@TrottTrott added the python PRs and issues that require attention from people who are familiar with Python. label Dec 15, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34961/

@TrottTrott closed this Dec 17, 2020
@Trott
Trott merged commit 32d58d7 into nodejs:masterDec 17, 2020
@Trott

Trott commented Dec 17, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 32d58d7

@Trott
Trott deleted the write-config branch December 17, 2020 13:20
targos pushed a commit that referenced this pull request Dec 21, 2020
@Trott@targos
tools: remove unused variable in configure.py
c6700ad
PR-URL: #36525
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott@targos
tools: remove unused variable in configure.py
1f3c129
PR-URL: #36525
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.pythonPRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@targos@aduh95