Uh oh!
There was an error while loading. Please reload this page.
test: redirect stderr EnvironmentWithNoESMLoader - #36548
Conversation
nodejs-github-bot
commented
Dec 17, 2020
This comment has been minimized.
This comment has been minimized.
6f32a6f to
42fd093CompareTrott
commented
Dec 17, 2020
This writes the output file to the current directory, right? I guess the |
|
danbev
commented
Dec 17, 2020
It does, but it also removes the file it writes in the destructor. The assumption here is that one would not be interested in the stderr output, but could just comment out the line if wanting to see the output while developing (or tail the file redirected to while debugging would also work). |
nodejs-github-bot
commented
Dec 17, 2020
42fd093 to
4214584CompareUh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Dec 22, 2020
nodejs-github-bot
commented
Dec 22, 2020
danbev
commented
Dec 23, 2020
Re-run of failing node-test-commit-aix ✔️ |
This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.
The motivation for this is that currently this tests prints the
following error (which is expected):
vm:module(0):1
globalThis.importResult = import("")
^
Error: Not supported
at vm:module(0):1:1
at SourceTextModule.evaluate (node:internal/vm/module:229:23)
at node:embedder_main_12:1:328
at processTicksAndRejections (node:internal/process/task_queues:93:5)
It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.
PR-URL: nodejs#36548
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>cc74364 to
3b0ecfcCompareTrott
commented
Dec 24, 2020
Landed in 3b0ecfc |
This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.
The motivation for this is that currently this tests prints the
following error (which is expected):
vm:module(0):1
globalThis.importResult = import("")
^
Error: Not supported
at vm:module(0):1:1
at SourceTextModule.evaluate (node:internal/vm/module:229:23)
at node:embedder_main_12:1:328
at processTicksAndRejections (node:internal/process/task_queues:93:5)
It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.
PR-URL: #36548
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.
The motivation for this is that currently this tests prints the
following error (which is expected):
vm:module(0):1
globalThis.importResult = import("")
^
Error: Not supported
at vm:module(0):1:1
at SourceTextModule.evaluate (node:internal/vm/module:229:23)
at node:embedder_main_12:1:328
at processTicksAndRejections (node:internal/process/task_queues:93:5)
It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.
PR-URL: #36548
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.The motivation for this is that currently this tests prints the
following error (which is expected):
It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes