Uh oh!
There was an error while loading. Please reload this page.
[v14.x] Revert "http: lazy create IncomingMessage.headers" - #36553
Closed
BethGriggs wants to merge 1 commit into
Closed
[v14.x] Revert "http: lazy create IncomingMessage.headers"#36553BethGriggs wants to merge 1 commit into
BethGriggs wants to merge 1 commit into
Conversation
This reverts commit b58725c. Fixes: nodejs#36550
Collaborator
richardlau
approved these changes
Dec 17, 2020
aduh95
approved these changes
Dec 17, 2020
BethGriggs
commented
Dec 17, 2020
MemberAuthor
Landed in 29fac46 |
BethGriggs added a commit
that referenced
this pull request
Dec 17, 2020
This reverts commit b58725c. Fixes: #36550 PR-URL: #36553 Refs: #35281 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This was referenced Sep 13, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b58725c.
Fixes: #36550
Refs: #35281
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes