doc: fix the exception description

[yorkie]

A value shouldn't be described as doing inherit from some class, more
strictly, the value is an instance of the class Error.

Just read the new documentation of Node.js, and raise this up :-)

/cc @chrisdickinson

[Fishrock123]

@nodejs/documentation

[Trott]

I would prefer changing ...it is not required that these values inherit from... to ...it is not required that exceptions inherit from... and leave it at that. Here's why:

• I'm not sure that introducing the word class doesn't cause more problems in this context than the word inherit.
• This usage is pretty typical anyway and I'm not sure that there is much to be gained by getting too hung up on it. This MDN doc includes p is an object that inherits from o and so on and so forth and it just doesn't seem problematic.
• I find the original shorter version easier to read and understand than the currently proposed longer version. This is a way to eliminate the value objection but also keep the sentence short and easy to understand.

[yorkie]

I'm not sure that introducing the word class doesn't cause more problems in this context than the word inherit.

The class has been introduced by ES6 itself, so I don't think we could keep skipping this problem.

This usage is pretty typical anyway and I'm not sure that there is much to be gained by getting too hung up on it. This MDN doc includes p is an object that inherits from o and so on and so forth and it just doesn't seem problematic.

Even thought MDN and wikipedia specify the inheritance is for an object or class, but for future JavaScript usage, the inheritance would look like:

classFooextendsBar{
...
}

And we cannot do like this:

(newFoo)extendsBar;// syntax error

So, I think to keep the consistence with ES6's syntax, we should change the description to: inheritance should only on classes.

I find the original shorter version easier to read and understand than the currently proposed longer version. This is a way to eliminate the value objection but also keep the sentence short and easy to understand.

100% agreed on changing from value to that exceptions, it as well should be more clear :-)

[yorkie]

Closing because of inactivity, thank you guys

[Trott]

If you wish to re-open, the last version you had LGTM.

[yorkie]

Really? I thought you rejected it :-(

[Trott]

I had some comments, and you addressed them. I thought it was fine. Sorry I didn't make that clear! Maybe let's see if we can get one more person's opinion? /cc @nodejs/documentation

[yorkie]

Lol, never mind, REOPEN-ing, thank you :-)

[Trott]

Nit: The scare quotes around exception are unnecessary IMO. Since we're editing nearby text, maybe this is a good opportunity to remove them. Totally optional, feel free to ignore, I'm fine with the change as is.

[yorkie]

@Trott Agreed and fixed :-)

[Trott]

LGTM. Unless someone else has an objection, I'll land this on Monday UTC. (It's a major holiday in the U.S. today, so I want to give some time for people to chime in, since the issue was dormant for so long. Thanks for your patience!)

[evanlucas]

LGTM

[Qard]

LGTM too. 👍

[cjihrig]

LGTM

[Trott]

Landed in 2fb34b6