Uh oh!
There was an error while loading. Please reload this page.
doc: remove "Related Issues" from pull request template - #36590
Closed
Trott wants to merge 2 commits into
Closed
Conversation
richardlau
left a comment
Member
There was a problem hiding this comment.
The template is replicated in doc/guides/contributing/pull-requests.md (this seems like a maintenance annoyance to me if we have to keep them in step. See https://github.com/nodejs/node/pull/36440/files (the PR that added the section being removed).
Trott
commented
Dec 21, 2020
MemberAuthor
This pull request now eliminates that maintenance annoyance by linking to the raw GitHub template. |
richardlau
approved these changes
Dec 21, 2020
targos
approved these changes
Dec 21, 2020
aduh95
approved these changes
Dec 21, 2020
aduh95
reviewed
Dec 21, 2020
Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
Dec 21, 2020
watilde
approved these changes
Dec 22, 2020
Trott
commented
Dec 22, 2020
MemberAuthor
If anyone needs more reasons to LGTM this: I just noticed that when the section isn't filled in, it ends up causing node-core-utils to insert broken metadata into commit messages. This is flagged by core-validate-commit so the lander gets to fix it first, but that's an annoyance and it also breaks the automated commit queue. |
We don't require an issue for a pull request, so this section usually ends up displaying confusing default content. PR-URL: nodejs#36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
The pull-request template was replicated in the pull-requests.md which is a maintenance annoyance when changing the template. Replace the replication with a link to the raw template. PR-URL: nodejs#36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott
commented
Dec 23, 2020
MemberAuthor
Landed in e22b751...2c8751c |
danielleadams pushed a commit
that referenced
this pull request
Jan 12, 2021
We don't require an issue for a pull request, so this section usually ends up displaying confusing default content. PR-URL: #36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 12, 2021
The pull-request template was replicated in the pull-requests.md which is a maintenance annoyance when changing the template. Replace the replication with a link to the raw template. PR-URL: #36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
May 1, 2021
We don't require an issue for a pull request, so this section usually ends up displaying confusing default content. PR-URL: #36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
The pull-request template was replicated in the pull-requests.md which is a maintenance annoyance when changing the template. Replace the replication with a link to the raw template. PR-URL: #36590 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't require an issue for a pull request. This section
ends up displaying confusing default content.
Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes