Skip to content

lib: refactor to use validateAbortSignal - #36604

Merged
Trott merged 1 commit into
nodejs:masterfrom
Lxxyx:refactor-to-use-validate-abort-signal
Dec 27, 2020
Merged

lib: refactor to use validateAbortSignal#36604
Trott merged 1 commit into
nodejs:masterfrom
Lxxyx:refactor-to-use-validate-abort-signal

Conversation

@Lxxyx

@LxxyxLxxyx commented Dec 22, 2020•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Dec 22, 2020
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35045/

lpinca
lpinca reviewed Dec 22, 2020
View reviewed changes
Comment threadlib/internal/quic/core.js Outdated
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35049/

@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35050/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2020
@Lxxyx@Trott
quic,timers: refactor to use validateAbortSignal
4905501
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@Trott
Trottforce-pushed the refactor-to-use-validate-abort-signal branch from e402095 to 4905501CompareDecember 27, 2020 14:38
@Trott
Trott merged commit 4905501 into nodejs:masterDec 27, 2020
@Trott

Trott commented Dec 27, 2020

Copy link
Copy Markdown
Member

Landed in 4905501

@Lxxyx
Lxxyx deleted the refactor-to-use-validate-abort-signal branch December 27, 2020 15:01
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx@danielleadams
quic,timers: refactor to use validateAbortSignal
8b7336b
PR-URL: #36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
@targostargos mentioned this pull request Apr 24, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@Lxxyx@targos
timers: refactor to use validateAbortSignal
130b797
PR-URL: nodejs#36604
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Lxxyx@targos
timers: refactor to use validateAbortSignal
1b74a08
PR-URL: #36604
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targostargos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca left review comments
@TrottTrottTrott approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@richardlaurichardlaurichardlau approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Lxxyx@nodejs-github-bot@Trott@benjamingr@lpinca@richardlau@juanarbol@targos@aduh95