Uh oh!
There was an error while loading. Please reload this page.
cluster: restructure to same prototype for cluster child - #36610
Closed
yashLadha wants to merge 1 commit into
Closed
cluster: restructure to same prototype for cluster child#36610yashLadha wants to merge 1 commit into
yashLadha wants to merge 1 commit into
Conversation
jasnell
approved these changes
Dec 31, 2020
nodejs-github-bot
commented
Feb 19, 2021
Collaborator
aduh95
commented
Feb 22, 2021
Contributor
This needs a rebase. |
marsonya
approved these changes
Feb 22, 2021
yashLadhaforce-pushed
the
fix_generic_handling
branch
2 times, most recently
from
February 26, 2021 01:15
87cdb48 to
1fac05eCompareSince `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing.
yashLadhaforce-pushed
the
fix_generic_handling
branch
from
February 26, 2021 01:19
1fac05e to
b122e83Comparenodejs-github-bot
commented
Feb 26, 2021
Collaborator
nodejs-github-bot
commented
Mar 1, 2021
Collaborator
jasnell
commented
Mar 5, 2021
Member
Landed in c199989 |
jasnell pushed a commit
that referenced
this pull request
Mar 5, 2021
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing. PR-URL: #36610 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 16, 2021
Since `rr` and `shared` both belongs to the same prototype declaration and differes only in the handler declaration, this can be abstracted to a same type of function arguments passing. PR-URL: #36610 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
rrandsharedboth belongs to the same prototype declarationand differes only in the handler declaration, this can be abstracted to
a same type of function arguments passing. Motivation behind this is they are
just extended handlers performing the same basic task so the layout (function structure)
should be consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes