Skip to content

test: improve coverage for util.inspect() with classes - #36625

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:util-inspect-class
Dec 27, 2020
Merged

test: improve coverage for util.inspect() with classes#36625
Trott merged 1 commit into
nodejs:masterfrom
Trott:util-inspect-class

Conversation

@Trott

Copy link
Copy Markdown
Member

Refs: #36622 (review)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott
Trott requested a review from BridgeARDecember 25, 2020 00:16
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 25, 2020
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Refs: nodejs#36622 (review)
PR-URL: nodejs#36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 75afb6c

@Trott
Trott merged commit 75afb6c into nodejs:masterDec 27, 2020
@Trott
Trott deleted the util-inspect-class branch December 27, 2020 04:31
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Refs: #36622 (review)
PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Refs: #36622 (review)
PR-URL: #36625
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@benjamingr@Lxxyx@aduh95