Skip to content

doc: document common warning types - #36713

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-warning-types
Closed

doc: document common warning types#36713
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-warning-types

Conversation

@jasnell

@jasnelljasnell commented Dec 31, 2020

Copy link
Copy Markdown
Member

Fixes: #24987
Signed-off-by: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Dec 31, 2020
RaisinTen
RaisinTen reviewed Jan 1, 2021
View reviewed changes
Comment threaddoc/api/process.md Outdated
Trott
Trott reviewed Jan 2, 2021
View reviewed changes
Comment threaddoc/api/process.md Outdated
Trott
Trott reviewed Jan 2, 2021
View reviewed changes
Comment threaddoc/api/process.md Outdated
jasnell
jasnell commented Jan 2, 2021
View reviewed changes
Comment threaddoc/api/process.md Outdated
jasnell
jasnell commented Jan 2, 2021
View reviewed changes
Comment threaddoc/api/process.md Outdated
@jasnell
doc: document common warning types
9d1cc32
Fixes: nodejs#24987
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jan 3, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 5499caa

@jasnelljasnell closed this Jan 3, 2021
jasnell added a commit that referenced this pull request Jan 3, 2021
@jasnell
doc: document common warning types
5499caa
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell@danielleadams
doc: document common warning types
242ce19
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: document common warning types
bcca52c
Fixes: #24987
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36713
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTenRaisinTenRaisinTen left review comments
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request for warning documentation

4 participants

@jasnell@Trott@RaisinTen@nodejs-github-bot