Skip to content

wasi: refactor to avoid unsafe array iteration - #36724

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:wasi-array-iteration
Jan 6, 2021
Merged

wasi: refactor to avoid unsafe array iteration#36724
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:wasi-array-iteration

Conversation

@aduh95

@aduh95aduh95 commented Jan 1, 2021

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the wasi Issues and PRs related to the WebAssembly System Interface. label Jan 1, 2021
Trott
Trott approved these changes Jan 2, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be telling you something you already know, but in the past, we've used for rather than .forEach() for performance purposes. I don't think either of these are hot paths, so it's probably fine. @nodejs/wasi

@aduh95

aduh95 commented Jan 2, 2021

Copy link
Copy Markdown
ContributorAuthor

I might be telling you something you already know, but in the past, we've used for rather than .forEach() for performance purposes. I don't think either of these are hot paths, so it's probably fine.

I'm running benchmarks on my other PRs with changes similar to this one, so far I haven't hit an perf issue. My guess is that both approaches are equivalent, but we can use a for(;;) loop instead if we find out that .forEach() is less efficient.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35295/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2021
@aduh95
wasi: refactor to avoid unsafe array iteration
08d8958
PR-URL: nodejs#36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95force-pushed the wasi-array-iteration branch from f553c8e to 08d8958CompareJanuary 6, 2021 10:34
@aduh95

aduh95 commented Jan 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 08d8958

@aduh95
aduh95 merged commit 08d8958 into nodejs:masterJan 6, 2021
@aduh95
aduh95 deleted the wasi-array-iteration branch January 6, 2021 10:34
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95@danielleadams
wasi: refactor to avoid unsafe array iteration
d5a9799
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@aduh95@targos
wasi: refactor to avoid unsafe array iteration
de1c976
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95@targos
wasi: refactor to avoid unsafe array iteration
b99ff61
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95@targos
wasi: refactor to avoid unsafe array iteration
0dea866
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.wasiIssues and PRs related to the WebAssembly System Interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@jasnell@Trott