Skip to content

tools: update ESLint to 7.17.0 - #36726

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:eslint
Closed

tools: update ESLint to 7.17.0#36726
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

Update ESLint to 7.17.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update ESLint to 7.17.0
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 2, 2021

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@yashLadhayashLadha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2021
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 4, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Landed in 5ad67a7...64a4001

nodejs-github-bot pushed a commit that referenced this pull request Jan 4, 2021
Update ESLint to 7.17.0
PR-URL: #36726
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@cjihrig
cjihrig deleted the eslint branch January 4, 2021 19:05
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Update ESLint to 7.17.0
PR-URL: #36726
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 16, 2021
Update ESLint to 7.17.0
PR-URL: #36726
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
Update ESLint to 7.17.0
PR-URL: #36726
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig@nodejs-github-bot@aduh95@yashLadha