Skip to content

doc: revise exit() and run() text in async_hooks.md - #36738

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:ah-exit-run
Jan 6, 2021
Merged

doc: revise exit() and run() text in async_hooks.md#36738
Trott merged 1 commit into
nodejs:masterfrom
Trott:ah-exit-run

Conversation

@Trott

@TrottTrott commented Jan 2, 2021

Copy link
Copy Markdown
Member

Edit for brevity and clarity. Use present tense where possible.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 2, 2021
@Trott

Trott commented Jan 5, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/documentation

@Trott

Trott commented Jan 5, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/async_hooks

Edit for brevity and clarity. Use present tense where possible.
PR-URL: nodejs#36738
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@Trott
Trott merged commit dd14dba into nodejs:masterJan 6, 2021
@Trott

Trott commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in dd14dba

@Trott
Trott deleted the ah-exit-run branch January 6, 2021 04:51
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
Edit for brevity and clarity. Use present tense where possible.
PR-URL: #36738
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Edit for brevity and clarity. Use present tense where possible.
PR-URL: #36738
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@Flarna@puzpuzpuz@nodejs-github-bot