Skip to content

test: use faster variant for rss in test-crypto-dh-leak.js - #36766

Closed
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:rss
Closed

test: use faster variant for rss in test-crypto-dh-leak.js#36766
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:rss

Conversation

@PoojaDurgad

@PoojaDurgadPoojaDurgad commented Jan 4, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #34291

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 4, 2021
Trott
Trott requested changes Jan 5, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me but it's not desirable (in my opinion, at least) to have multiple identical commit messages. Can we please update the commit message for this and the other PRs with identical names/commit messages so that they indicate the name of the test that is being changed?

@PoojaDurgadPoojaDurgad changed the title test: use faster variant for rsstest: use faster variant for rss in test-crypto-dh-leak.jsJan 5, 2021
@PoojaDurgad

PoojaDurgad commented Jan 5, 2021

Copy link
Copy Markdown
ContributorAuthor

Change looks good to me but it's not desirable (in my opinion, at least) to have multiple identical commit messages. Can we please update the commit message for this and the other PRs with identical names/commit messages so that they indicate the name of the test that is being changed?

yeah, fixed

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35265/

@PoojaDurgadPoojaDurgad added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35279/

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
mhdawson
mhdawson approved these changes Jan 8, 2021
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35373/

@PoojaDurgadPoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 11, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35441/

@jasnell

jasnell commented Jan 11, 2021

Copy link
Copy Markdown
Member

Landed in f4ef517

@jasnelljasnell closed this Jan 11, 2021
jasnell pushed a commit that referenced this pull request Jan 11, 2021
@PoojaDurgad@jasnell
test: use faster variant for rss in test-crypto-dh-leak
f4ef517
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@PoojaDurgad@danielleadams
test: use faster variant for rss in test-crypto-dh-leak
cc37ff2
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request Aug 8, 2021
@PoojaDurgad@targos
test: use faster variant for rss in test-crypto-dh-leak
dade545
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@PoojaDurgad@BethGriggs
test: use faster variant for rss in test-crypto-dh-leak
df594e7
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
@PoojaDurgad@MylesBorins
test: use faster variant for rss in test-crypto-dh-leak
d4362db
PR-URL: #36766
Refs: #34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@FlarnaFlarnaFlarna approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@PoojaDurgad@nodejs-github-bot@jasnell@Trott@mhdawson@Flarna@targos