Skip to content

readline: fix behaviour of Interface plugged to a non-terminal output - #36774

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:setupHistory-non-terminal-repl
Jan 6, 2021
Merged

readline: fix behaviour of Interface plugged to a non-terminal output#36774
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:setupHistory-non-terminal-repl

Conversation

@aduh95

@aduh95aduh95 commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Fixes: #36773

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • Tests are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jan 4, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35291/

@aduh95
readline: fix behaviour of Interface plugged to a non-terminal output
fffdaeb
Fixes: nodejs#36773
PR-URL: nodejs#36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@aduh95
aduh95force-pushed the setupHistory-non-terminal-repl branch from 233432d to fffdaebCompareJanuary 6, 2021 17:45
@aduh95

aduh95 commented Jan 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in fffdaeb

@aduh95
aduh95 merged commit fffdaeb into nodejs:masterJan 6, 2021
@aduh95
aduh95 deleted the setupHistory-non-terminal-repl branch January 6, 2021 17:46
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95@danielleadams
readline: fix behaviour of Interface plugged to a non-terminal output
b17130a
Fixes: #36773
PR-URL: #36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95@targos
readline: fix behaviour of Interface plugged to a non-terminal output
70cbe4a
Fixes: #36773
PR-URL: #36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@LxxyxLxxyxLxxyx approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.setupHistory() for non-terminal REPL fails

5 participants

@aduh95@nodejs-github-bot@addaleax@cjihrig@Lxxyx