Skip to content

doc: clarify when messageerror is emitted - #36780

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-messageerror
Closed

doc: clarify when messageerror is emitted#36780
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-messageerror

Conversation

@jasnell

@jasnelljasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

Adapting addaleax's explanation from the issue.

Fixes: #36333
Signed-off-by: James M Snell jasnell@gmail.com
/cc @addaleax@naz

@jasnell
doc: clarify when messageerror is emitted
c09df40
Adapting addaleax's explanation from the issue.
Fixes: nodejs#36333
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jan 4, 2021
RaisinTen
RaisinTen reviewed Jan 5, 2021
View reviewed changes
Comment threaddoc/api/worker_threads.md Outdated
@jasnell@RaisinTen
[squash] nit
2b863d1
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 9ac4047

@jasnelljasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
@jasnell
doc: clarify when messageerror is emitted
9ac4047
Adapting addaleax's explanation from the issue.
Fixes: #36333
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell@danielleadams
doc: clarify when messageerror is emitted
b4091ea
Adapting addaleax's explanation from the issue.
Fixes: #36333
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: clarify when messageerror is emitted
a800b5b
Adapting addaleax's explanation from the issue.
Fixes: #36333
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTenRaisinTenRaisinTen left review comments
@addaleaxaddaleaxaddaleax approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: unclear conditions under which Worker's 'messageerror' is emmited

5 participants

@jasnell@addaleax@juanarbol@RaisinTen@nodejs-github-bot