Skip to content

doc: clarify subprocess.stdout/in/err/io properties - #36784

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-stdio-null
Closed

doc: clarify subprocess.stdout/in/err/io properties#36784
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-clarify-stdio-null

Conversation

@jasnell

@jasnelljasnell commented Jan 4, 2021

Copy link
Copy Markdown
Member

The various subprocess.stdwhatever properties can be null or
undefined in certain conditions.

Fixes: #33458
Signed-off-by: James M Snell jasnell@gmail.com

@jasnell
doc: clarify subprocess.stdout/in/err/io properties
8da0b14
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.
Fixes: nodejs#33458
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jan 4, 2021
@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

This shouldn't need to wait the full time to land. Please 👍🏻 to fast-track

jasnell added a commit that referenced this pull request Jan 7, 2021
@jasnell
doc: clarify subprocess.stdout/in/err/io properties
8ce6583
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.
Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 8ce6583

@jasnelljasnell closed this Jan 7, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell@danielleadams
doc: clarify subprocess.stdout/in/err/io properties
d4bcb36
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.
Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: clarify subprocess.stdout/in/err/io properties
c1ea23c
The various `subprocess.stdwhatever` properties can be null or
undefined in certain conditions.
Fixes: #33458
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #36784
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: child_process.SpawnSync output, stdout, stderr can be null

3 participants

@jasnell@lpinca@nodejs-github-bot