Skip to content

doc: clarify that --require only supports cjs - #36806

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-require-cli-cjs
Closed

doc: clarify that --require only supports cjs#36806
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-require-cli-cjs

Conversation

@jasnell

@jasnelljasnell commented Jan 5, 2021

Copy link
Copy Markdown
Member

Fixes: #35103

@nodejs-github-botnodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jan 5, 2021
MylesBorins
MylesBorins approved these changes Jan 5, 2021
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2021
@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

This shouldn't need to wait the full time to land. Please 👍🏻 to fast track

@jasnell

jasnell commented Jan 6, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 9d35b92

@jasnelljasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
@jasnell
doc: clarify that --require only supports cjs
9d35b92
Fixes: #35103
PR-URL: #36806
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell@danielleadams
doc: clarify that --require only supports cjs
a7bb4da
Fixes: #35103
PR-URL: #36806
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: clarify that --require only supports cjs
1521a59
Fixes: #35103
PR-URL: #36806
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@watildewatildewatilde approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@aduh95aduh95aduh95 approved these changes
@HarshithaKPHarshithaKPHarshithaKP approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cliIssues and PRs related to the Node.js command line interface.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--require doesn't work with import

8 participants

@jasnell@MylesBorins@addaleax@watilde@BethGriggs@aduh95@HarshithaKP@nodejs-github-bot