Skip to content

stream: add readableDidRead - #36820

Closed
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:http-manualStart
Closed

stream: add readableDidRead#36820
ronag wants to merge 3 commits into
nodejs:masterfrom
nxtedition:http-manualStart

Conversation

@ronag

@ronagronag commented Jan 6, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Adds readableDidRead to streams and applies usage to http.

@ronagronag added http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem. http2 Issues or PRs related to the http2 subsystem. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Jan 6, 2021
@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2021
@ronag
ronag requested a review from lpincaJanuary 6, 2021 20:45
@ronagronag removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2021
mscdex
mscdex reviewed Jan 6, 2021
View reviewed changes
Comment threadtest/parallel/test-stream-readable-manualStart.js Outdated
mscdex
mscdex reviewed Jan 6, 2021
View reviewed changes
Comment threadtest/parallel/test-stream-readable-manualStart.js Outdated
mscdex
mscdex reviewed Jan 6, 2021
View reviewed changes
Comment threadtest/parallel/test-stream-readable-manualStart.js Outdated
@ronag
ronag marked this pull request as draft January 6, 2021 21:40
@ronag
ronagforce-pushed the http-manualStart branch 3 times, most recently from 36596e7 to 823908dCompareJanuary 6, 2021 22:32
@ronag

This comment has been minimized.

Sign in to view
@ronag
ronagforce-pushed the http-manualStart branch 2 times, most recently from eae9165 to f89ab33CompareJanuary 6, 2021 22:42
@ronagronag changed the title stream: add manualStartstream: add readableDidReadJan 6, 2021
@ronag
ronag marked this pull request as ready for review January 6, 2021 22:44
@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021
@ronag
ronag marked this pull request as draft January 6, 2021 22:59
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35343/

@ronag
ronag marked this pull request as ready for review January 6, 2021 23:08
@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed http2 Issues or PRs related to the http2 subsystem. labels Jul 8, 2021
@ronag

ronag commented Jul 8, 2021

Copy link
Copy Markdown
MemberAuthor

@benjamingr@vweevers

@ronagronag mentioned this pull request Jul 9, 2021
Closed
@targostargos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2021
mcollina
mcollina reviewed Jul 13, 2021
View reviewed changes
Comment threadlib/_http_server.js
@ronag
ronag requested a review from mcollinaJuly 13, 2021 21:53
mcollina
mcollina approved these changes Jul 14, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Jul 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39042/

ronag added a commit that referenced this pull request Jul 14, 2021
@ronag
stream: add readableDidRead
8306051
Adds readableDidRead to streams and applies usage to http, http2 and quic.
PR-URL: #36820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag

ronag commented Jul 14, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 8306051

@ronagronag closed this Jul 14, 2021
targos pushed a commit that referenced this pull request Jul 17, 2021
@ronag@targos
stream: add readableDidRead
8fe7d23
Adds readableDidRead to streams and applies usage to http, http2 and quic.
PR-URL: #36820
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Jul 26, 2021
Merged
@targos

targos commented Jul 27, 2021

Copy link
Copy Markdown
Member

Is it intended to be public API? In that case it should be documented and this PR is semver-minor.

@targos

targos commented Jul 29, 2021

Copy link
Copy Markdown
Member

@ronag ^

@ronagronag added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 29, 2021
@ronag

ronag commented Jul 30, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Added don't land tags for now due to ongoing discussions.

@targos

targos commented Aug 22, 2021

Copy link
Copy Markdown
Member

Where are the discussions happening?

@targos

targos commented Aug 22, 2021

Copy link
Copy Markdown
Member

Oh I see, it was reverted and implemented differently in #39589

@BethGriggsBethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@apapirovskiapapirovskiAwaiting requested review from apapirovski
@lpincalpincaAwaiting requested review from lpinca
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.review wantedPRs that need reviews.semver-minorPRs that contain new features and should be released in the next minor version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@nodejs-github-bot@mscdex@jasnell@targos@mcollina@benjamingr