Skip to content

tools: update doc tool dependencies - #36844

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-doctool
Closed

tools: update doc tool dependencies#36844
targos wants to merge 1 commit into
nodejs:masterfrom
targos:update-doctool

Conversation

@targos

@targostargos commented Jan 8, 2021•
edited
Loading

Copy link
Copy Markdown
Member

The only change in the output is for http blocks like this one:

```http
GET /status?name=ryan HTTP/1.1
Accept: text/plain
```

It generates a different markup but there is no visual difference:

Before:
image
image

After:
image
image

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 8, 2021
aduh95
aduh95 approved these changes Jan 8, 2021•
edited
Loading
View reviewed changes
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 8, 2021
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35366/

@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35384/

@targos

targos commented Jan 11, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 9883fe0

@targostargos closed this Jan 11, 2021
@targos
targos deleted the update-doctool branch January 11, 2021 07:13
targos added a commit that referenced this pull request Jan 11, 2021
@targos
tools: update doc tool dependencies
9883fe0
PR-URL: #36844
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@targos@danielleadams
tools: update doc tool dependencies
cfdbb79
PR-URL: #36844
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jan 12, 2021
Merged
targos added a commit that referenced this pull request May 1, 2021
@targos
tools: update doc tool dependencies
aef7697
PR-URL: #36844
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@watildewatildewatilde approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@jasnell@Trott@watilde@aduh95