Skip to content

chore: update fs.l/statSync API history for throwIfNoEntry - #36882

Closed
amcasey wants to merge 2 commits into
nodejs:masterfrom
amcasey:NoThrowsStatHistory
Closed

chore: update fs.l/statSync API history for throwIfNoEntry#36882
amcasey wants to merge 2 commits into
nodejs:masterfrom
amcasey:NoThrowsStatHistory

Conversation

@amcasey

@amcaseyamcasey commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

As suggested here, now that there's a version number, the history in the API document can be updated to reflect this PR.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 12, 2021
@amcasey

amcasey commented Jan 12, 2021

Copy link
Copy Markdown
ContributorAuthor

FYI @merceyz

mscdex
mscdex reviewed Jan 12, 2021
View reviewed changes
Comment threaddoc/api/fs.md Outdated
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2021
@jasnelljasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 12, 2021
@aduh95aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 12, 2021
@aduh95

aduh95 commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

@jasnell I removed the request-ci label because this is a doc-only change.

@jasnell

jasnell commented Jan 14, 2021

Copy link
Copy Markdown
Member

Landed in 8f32733

@jasnelljasnell closed this Jan 14, 2021
jasnell pushed a commit that referenced this pull request Jan 14, 2021
@amcasey@jasnell
doc: update fs.l/statSync API history for throwIfNoEntry
8f32733
PR-URL: #36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 14, 2021
@amcasey@aduh95
doc: update fs.l/statSync API history for throwIfNoEntry
8b03585
PR-URL: nodejs#36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Jan 14, 2021
Closed
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@amcasey@ruyadorno
doc: update fs.l/statSync API history for throwIfNoEntry
82eccdd
PR-URL: #36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request Apr 26, 2021
@amcasey@targos
doc: update fs.l/statSync API history for throwIfNoEntry
5a3e12b
PR-URL: #36882
Backport-PR-URL: #36921
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 26, 2021
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amcasey@aduh95@jasnell@mscdex@targos@nodejs-github-bot