Uh oh!
There was an error while loading. Please reload this page.
crypto: fix randomInt bias - #36894
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>
3 tasks
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/35470/ Infrastructure failure: |
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/35471/ Infrastructure failure: |
puzpuzpuz
approved these changes
Jan 12, 2021
nodejs-github-bot
commented
Jan 12, 2021
Collaborator
jasnell
approved these changes
Jan 12, 2021
tniessen
commented
Jan 12, 2021
MemberAuthor
The asan failure seems related to #36779 and is unrelated to this change. |
nodejs-github-bot
commented
Jan 14, 2021
Collaborator
nodejs-github-bot
commented
Jan 14, 2021
Collaborator
Collaborator
tniessen
commented
Jan 14, 2021
MemberAuthor
Landed in 4db9854, thanks for reviewing. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@puzpuzpuz found this issue in #35110 (comment). Opening a separate PR to make sure this fix can land and be backported quickly, if necessary.
This patch also changes a few comments and definitions to make the necessary conditions easier to understand.
The actual effect of this bias is small, but the mere existence of bias defeats the purpose of this function.
Refs: #34600