Skip to content

url: align url format behavior with browsers - #36903

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-url-format
Closed

url: align url format behavior with browsers#36903
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-url-format

Conversation

@Lxxyx

@LxxyxLxxyx commented Jan 13, 2021

Copy link
Copy Markdown
Member

Fixes: #36887

targos
targos reviewed Jan 13, 2021
View reviewed changes
Comment threadtest/parallel/test-url-override-hostname.js Outdated
targos
targos reviewed Jan 13, 2021
View reviewed changes
Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated
@Lxxyx
Lxxyx requested a review from targosJanuary 13, 2021 10:07
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35498/

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35503/

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35506/

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35514/

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35518/

@jasnell
jasnell requested a review from addaleaxJanuary 13, 2021 14:26
RaisinTen
RaisinTen reviewed Jan 13, 2021
View reviewed changes
Comment threadtest/parallel/test-whatwg-url-override-hostname.js Outdated
jasnell
jasnell reviewed Jan 13, 2021
View reviewed changes
Comment threadtest/parallel/test-whatwg-url-override-hostname.js Outdated
@aduh95aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35552/

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 14, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35554/

@Lxxyx@aduh95
url: align url format behavior with browsers
9566083
Fixes: nodejs#36887
PR-URL: nodejs#36903
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@aduh95

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Landed in 9566083

@aduh95aduh95 closed this Jan 18, 2021
@Lxxyx
Lxxyx deleted the fix-url-format branch January 18, 2021 11:01
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Lxxyx@ruyadorno
url: align url format behavior with browsers
889654d
Fixes: #36887
PR-URL: #36903
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Lxxyx@targos
url: align url format behavior with browsers
d13fc6e
Fixes: #36887
PR-URL: #36903
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell left review comments
@RaisinTenRaisinTenRaisinTen left review comments
@addaleaxaddaleaxaddaleax approved these changes
@watildewatildewatilde approved these changes
@targostargostargos approved these changes
@juanarboljuanarboljuanarbol approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URL href mismatch from browsers

11 participants

@Lxxyx@nodejs-github-bot@aduh95@jasnell@addaleax@TimothyGu@watilde@targos@juanarbol@ZYSzys@RaisinTen