Skip to content

test: fix variable name for non-RSA keys - #36912

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-fix-rsa-key-var-name
Closed

test: fix variable name for non-RSA keys#36912
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-fix-rsa-key-var-name

Conversation

@tniessen

@tniessentniessen commented Jan 13, 2021

Copy link
Copy Markdown
Member

The point here is that the keys are not RSA keys, so the variable name rsaKeys is misleading/wrong. These ECDSA keys are used to test that the RSA algorithm rejects non-RSA keys.

@tniessentniessen added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Jan 13, 2021
@tniessen
tniessen requested a review from jasnellJanuary 13, 2021 14:53
@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@tniessentniessen added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 13, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35549/

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
tniessen added a commit that referenced this pull request Jan 15, 2021
@tniessen
test: fix variable name for non-RSA keys
ccc6776
PR-URL: #36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen

tniessen commented Jan 15, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in ccc6776, thanks for reviewing.

@tniessen
tniessen deleted the test-fix-rsa-key-var-name branch January 15, 2021 17:14
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@tniessen@ruyadorno
test: fix variable name for non-RSA keys
30b2aac
PR-URL: #36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@panva@lpinca@cjihrig@targos