Skip to content

doc: change "it's" to "its" where necessary - #36913

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-fix-its-its
Closed

doc: change "it's" to "its" where necessary#36913
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-fix-its-its

Conversation

@tniessen

Copy link
Copy Markdown
Member

No description provided.

@tniessentniessen added the doc Issues and PRs related to the documentations. label Jan 13, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2021

@ItzLevvieItzLevvie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tniessen

tniessen commented Jan 13, 2021

Copy link
Copy Markdown
MemberAuthor

Collaborators, please add 👍 here to approve fast-tracking this PR.

Edit: Approved by @targos, @cjihrig, @aduh95, and @PoojaDurgad. Fast-tracking.

@tniessentniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2021
@aduh95aduh95 added fast-track PRs that do not need to wait for 48 hours to land. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 13, 2021
@aduh95

Copy link
Copy Markdown
Contributor

I removed the request-ci as this is a doc-only change, and doesn't require a full CI run.

@tniessen

Copy link
Copy Markdown
MemberAuthor

PR-URL: nodejs#36913
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95

Copy link
Copy Markdown
Contributor

Landed in 302060a

@aduh95aduh95 closed this Jan 13, 2021
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
@tniessen
tniessen deleted the doc-fix-its-its branch January 15, 2021 17:14
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36913
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen@aduh95@lpinca@targos@cjihrig@richardlau@ItzLevvie@PoojaDurgad