Uh oh!
There was an error while loading. Please reload this page.
lib: refactor to use optional chaining in internal/options.js - #36939
Merged
Trott merged 0 commit intoJan 24, 2021
Merged
Conversation
jasnell
approved these changes
Jan 15, 2021
Contributor
I'd rather have #36652 landed TBH (or closed if we don't want to do it). Removing |
RaisinTen
commented
Jan 15, 2021
MemberAuthor
@aduh95 sure, no problem! :) |
aduh95
approved these changes
Jan 19, 2021
nodejs-github-bot
commented
Jan 23, 2021
Collaborator
nodejs-github-bot
commented
Jan 23, 2021
Collaborator
nodejs-github-bot
commented
Jan 24, 2021
Collaborator
Trott
approved these changes
Jan 24, 2021
Trottforce-pushed
the
lib/refactor-to-use-optional-chaining-in-internal/options.js
branch
from
January 24, 2021 16:20
758c8cb to
85e6089CompareTrott
commented
Jan 24, 2021
Member
Landed in 85e6089 |
RaisinTen
deleted the
lib/refactor-to-use-optional-chaining-in-internal/options.js
branch
January 24, 2021 16:24
targos pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.