Skip to content

doc: clarify maxSockets option of http.Agent - #36941

Closed
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:max-socket
Closed

doc: clarify maxSockets option of http.Agent#36941
PoojaDurgad wants to merge 1 commit into
nodejs:masterfrom
PoojaDurgad:max-socket

Conversation

@PoojaDurgad

@PoojaDurgadPoojaDurgad commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

fixes: #36463

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jan 15, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@PoojaDurgad@jasnell
doc: clarify maxSockets option of http.Agent
090f0cd
PR-URL: #36941Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@jasnell

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Landed in 090f0cd

@jasnelljasnell closed this Jan 18, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@PoojaDurgad@ruyadorno
doc: clarify maxSockets option of http.Agent
5693ed9
PR-URL: #36941Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@PoojaDurgad@ruyadorno
doc: clarify maxSockets option of http.Agent
7ea374b
PR-URL: #36941Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@PoojaDurgad@targos
doc: clarify maxSockets option of http.Agent
385d0df
PR-URL: #36941Fixes: #36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: http.Agent, reuse single socket vs new socket for each request

4 participants

@PoojaDurgad@jasnell@aduh95@nodejs-github-bot