Skip to content

doc: improve AsyncLocalStorage introduction - #36946

Closed
brillout wants to merge 6 commits into
nodejs:masterfrom
brillout:patch-2
Closed

doc: improve AsyncLocalStorage introduction#36946
brillout wants to merge 6 commits into
nodejs:masterfrom
brillout:patch-2

Conversation

@brillout

@brilloutbrillout commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

I've tried to comply to the contributing guidlines although I skimed over some of it; hopefully I didn't miss anything.

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 15, 2021
vdeturckheim
vdeturckheim suggested changes Jan 15, 2021
View reviewed changes

@vdeturckheimvdeturckheim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally LGTM, @puzpuzpuz@Flarna@Qard maybe you want to take a look :)

Comment threaddoc/api/async_hooks.md Outdated
Comment threaddoc/api/async_hooks.md Outdated
puzpuzpuz
puzpuzpuz reviewed Jan 15, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md Outdated
puzpuzpuz
puzpuzpuz reviewed Jan 15, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md Outdated
puzpuzpuz
puzpuzpuz reviewed Jan 15, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md Outdated
Qard
Qard requested changes Jan 15, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md Outdated
Comment threaddoc/api/async_hooks.md Outdated
Comment threaddoc/api/async_hooks.md Outdated
@brillout

brillout commented Jan 18, 2021

Copy link
Copy Markdown
ContributorAuthor

@vdeturckheim
@Qard
@puzpuzpuz

I rewrote and shorten the paragraph; I believe it resolves all issues.

vdeturckheim
vdeturckheim approved these changes Jan 18, 2021
View reviewed changes

@vdeturckheimvdeturckheim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

puzpuzpuz
puzpuzpuz reviewed Jan 19, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md Outdated
Comment threaddoc/api/async_hooks.md Outdated
@puzpuzpuz
puzpuzpuz self-requested a review January 19, 2021 13:14
Qard
Qard reviewed Jan 19, 2021
View reviewed changes
Comment threaddoc/api/async_hooks.md
Comment threaddoc/api/async_hooks.md Outdated
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

Landed in 63d978c

@jasnelljasnell closed this Jan 25, 2021
jasnell pushed a commit that referenced this pull request Jan 25, 2021
@brillout@jasnell
doc: improve AsyncLocalStorage introduction
63d978c
PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 2, 2021
@brillout@targos
doc: improve AsyncLocalStorage introduction
c79688f
PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@brillout@targos
doc: improve AsyncLocalStorage introduction
49f1374
PR-URL: #36946
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@jasnelljasnelljasnell approved these changes
+2 more reviewers
@puzpuzpuzpuzpuzpuzpuzpuzpuz approved these changes
@vdeturckheimvdeturckheimvdeturckheim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brillout@jasnell@Qard@vdeturckheim@puzpuzpuz@nodejs-github-bot