Skip to content

deps: V8: cherry-pick fe191e8d05cc - #36956

Closed
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:coverage-optional-chain
Closed

deps: V8: cherry-pick fe191e8d05cc#36956
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:coverage-optional-chain

Conversation

@bcoe

@bcoebcoe commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

An unexercised optional chain did not count as a missed branch:

Before:

Screen Shot 2021-01-15 at 6 56 21 PM

After:

Screen Shot 2021-01-15 at 6 56 26 PM

Original commit message:

[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}

Refs: v8/v8@fe191e8

Benjamin Coe
deps: V8: cherry-pick fe191e8d05cc
0ca2a89
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jan 16, 2021
@bcoebcoe added the coverage Issues and PRs related to native coverage support. label Jan 16, 2021
@bcoe
bcoe requested a review from TrottJanuary 16, 2021 02:59
@nodejs-github-bot

nodejs-github-bot commented Jan 16, 2021•
edited by bcoe
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35571/ ✅
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3680/ ✅

@bcoebcoe added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 16, 2021
@bcoe

bcoe commented Jan 16, 2021

Copy link
Copy Markdown
ContributorAuthor

@targos@Trott any objection to fast track?

👍 👎

@bcoebcoe mentioned this pull request Jan 17, 2021
Closed
@aduh95aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2021
@aduh95

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Landed in afd911c

@aduh95aduh95 closed this Jan 18, 2021
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
Benjamin Coe@aduh95
deps: V8: cherry-pick fe191e8d05cc
afd911c
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: #36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
Benjamin Coe@ruyadorno
deps: V8: cherry-pick fe191e8d05cc
fdb9812
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: #36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
Benjamin Coe@ruyadorno
deps: V8: cherry-pick fe191e8d05cc
ca479b9
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: #36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 11, 2021
Benjamin Coe@targos
deps: V8: cherry-pick fe191e8d05cc
73e0245
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: nodejs#36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 12, 2021
Benjamin Coe@targos
deps: V8: cherry-pick fe191e8d05cc
80bc3c8
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: nodejs#36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 24, 2021
Benjamin Coe@targos
deps: V8: cherry-pick fe191e8d05cc
903e8b6
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: nodejs#36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Feb 24, 2021
Benjamin Coe@targos
deps: V8: cherry-pick fe191e8d05cc
bb2a98f
Original commit message:
[coverage] optional chaining coverage
Implement coverage tracking for optional chains.
Bug: v8:10060
Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Gus Caplan <snek@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Benjamin Coe <bencoe@google.com>
Cr-Commit-Position: refs/heads/master@{#72075}
Refs: v8/v8@fe191e8
PR-URL: #36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos

targos commented May 25, 2021

Copy link
Copy Markdown
Member

This lands cleanly on v14.x-staging but fails to build. It will either have to be backported manually or marked dont-land-on-v14.x instead.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.coverageIssues and PRs related to native coverage support.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bcoe@nodejs-github-bot@aduh95@targos@Trott