Skip to content

[docs] Fix grammar and link to QUIC - #36959

Closed
dandv wants to merge 1 commit into
nodejs:masterfrom
dandv:patch-2
Closed

[docs] Fix grammar and link to QUIC#36959
dandv wants to merge 1 commit into
nodejs:masterfrom
dandv:patch-2

Conversation

@dandv

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 16, 2021
gengjiawen
gengjiawen previously requested changes Jan 16, 2021

@gengjiawengengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: QUICK -> QUIC

@dandvdandv changed the title [docs] Fix grammar and link to QUICK[docs] Fix grammar and link to QUICJan 16, 2021
@aduh95

Copy link
Copy Markdown
Contributor

Typo: QUICK -> QUIC

This can be fixed when landing, to avoid having to run another CI just to fix the commit message.

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I wonder if the link should be https://developer.mozilla.org/en-US/docs/Glossary/QUIC rather than Wikipedia.

@aduh95

Copy link
Copy Markdown
Contributor

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

@gengjiawengengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever land this please fix commit message.

@gengjiawen
gengjiawen self-requested a review January 18, 2021 11:38
@gengjiawen

Copy link
Copy Markdown
Member

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

My objection is clear. But also this can be fixed by commiter, I have dismissed my objection with a comment.

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2021
@aduh95
aduh95 dismissed gengjiawen’s stale reviewJanuary 18, 2021 14:04

They dismissed their objection in a comment above.

@aduh95

Copy link
Copy Markdown
Contributor

Landed in 75a73c4

@aduh95aduh95 closed this Jan 18, 2021
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@dandv
dandv deleted the patch-2 branch January 19, 2021 03:02
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@dandv@aduh95@gengjiawen@Trott@HarshithaKP@PoojaDurgad@targos@nodejs-github-bot@RaisinTen