Skip to content

events: remove error listener on signal abort - #36969

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:events-once-remove-error-listener-on-abort
Closed

events: remove error listener on signal abort#36969
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:events-once-remove-error-listener-on-abort

Conversation

@Lxxyx

@LxxyxLxxyx commented Jan 16, 2021

Copy link
Copy Markdown
Member

Fixes: #36949

@nodejs-github-botnodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Jan 16, 2021
@nodejs-github-bot

nodejs-github-bot commented Jan 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35580/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2021
@jasnell

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Landed in 06c4693

@jasnelljasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@Lxxyx@jasnell
events: remove error listener on signal abort
06c4693
Fixes: #36949
PR-URL: #36969
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Lxxyx
Lxxyx deleted the events-once-remove-error-listener-on-abort branch January 18, 2021 21:42
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Lxxyx@ruyadorno
events: remove error listener on signal abort
abf0477
Fixes: #36949
PR-URL: #36969
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadornoruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@Lxxyx@ruyadorno
events: remove error listener on signal abort
dc596d0
Fixes: #36949
PR-URL: #36969
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

events.once creates an error listener that is not removed on abort.

7 participants

@Lxxyx@nodejs-github-bot@jasnell@benjamingr@lpinca@aduh95@targos