Skip to content

http: fix ClientRequest unhandled errors - #36970

Closed
ronag wants to merge 7 commits into
nodejs:masterfrom
nxtedition:http-client-unhandled
Closed

http: fix ClientRequest unhandled errors#36970
ronag wants to merge 7 commits into
nodejs:masterfrom
nxtedition:http-client-unhandled

Conversation

@ronag

@ronagronag commented Jan 16, 2021•
edited
Loading

Copy link
Copy Markdown
Member

ClientRequest could somtimes cause an unhandled error from socket.

Fixes: #36931

@ronag
http: fix ClientRequest unhandled errors
4fe8533
ClientRequest could someone cause an unhandled error
from socket.
Fixes: nodejs#36931
@ronagronag added http Issues or PRs related to the http subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 16, 2021
@ronag
ronag requested a review from lpincaJanuary 16, 2021 17:19
ronag
ronag commented Jan 16, 2021
View reviewed changes
Comment threadlib/_http_client.js Outdated
ronag
ronag commented Jan 16, 2021
View reviewed changes
Comment threadlib/_http_client.js
@ronag
ronag requested a review from dnlupJanuary 16, 2021 17:21
lpinca
lpinca reviewed Jan 16, 2021
View reviewed changes
Comment threadlib/_http_agent.js Outdated
lpinca
lpinca approved these changes Jan 16, 2021
View reviewed changes
Comment threadtest/parallel/test-http-client-abort3.js Outdated
@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 16, 2021
@ronag

ronag commented Jan 16, 2021

Copy link
Copy Markdown
MemberAuthor

@nodejs/http

lpinca
lpinca reviewed Jan 16, 2021
View reviewed changes
Comment threadlib/_http_client.js
@nodejs-github-bot

nodejs-github-bot commented Jan 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35583/

mcollina
mcollina approved these changes Jan 17, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2021
@ronag

ronag commented Jan 17, 2021

Copy link
Copy Markdown
MemberAuthor

Test needs improvment.

@dnlup

dnlup commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

I cannot reproduce the timeout error on test/parallel/test-cluster-primary-kill.js, it might be a temporary error.

dnlup
dnlup reviewed Jan 18, 2021
View reviewed changes

@dnlupdnlup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronagronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 3, 2021
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35918/

@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35919/

lpinca
lpinca reviewed Feb 3, 2021
View reviewed changes
Comment threadtest/parallel/test-http-client-abort3.js Outdated
@ronag@lpinca
Update test/parallel/test-http-client-abort3.js
d103ec1
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35920/

lpinca
lpinca reviewed Feb 3, 2021
View reviewed changes
Comment threadtest/parallel/test-http-client-abort3.js Outdated
@ronag@lpinca
Update test/parallel/test-http-client-abort3.js
a5cb23a
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35921/

ronag added a commit that referenced this pull request Feb 3, 2021
@ronag
http: fix ClientRequest unhandled errors
fe43bd8
ClientRequest could someone cause an unhandled error
from socket.
Fixes: #36931
PR-URL: #36970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag

ronag commented Feb 3, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in fe43bd8

@ronagronag closed this Feb 3, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@ronag@danielleadams
http: fix ClientRequest unhandled errors
4cdc5ea
ClientRequest could someone cause an unhandled error
from socket.
Fixes: #36931
PR-URL: #36970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
@panvapanva removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2023
@Changqing-JINGChangqing-JING mentioned this pull request Jun 9, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
+1 more reviewer
@dnlupdnlupdnlup approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhandled 'error' event on aborted request

8 participants

@ronag@nodejs-github-bot@dnlup@mcollina@benjamingr@lpinca@panva@targos