Skip to content

benchmark: improve explanations in R script - #36995

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:benchmark-r-explanations
Closed

benchmark: improve explanations in R script#36995
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:benchmark-r-explanations

Conversation

@tniessen

Copy link
Copy Markdown
Member

Just a few minor improvements to the comments in compare.R.

@tniessentniessen added the benchmark Issues and PRs related to the benchmark subsystem. label Jan 19, 2021
@PoojaDurgadPoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2021
jasnell pushed a commit that referenced this pull request Jan 23, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in ea2e2df

@jasnelljasnell closed this Jan 23, 2021
@tniessen
tniessen deleted the benchmark-r-explanations branch January 23, 2021 15:28
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen@jasnell@cjihrig@gengjiawen@aduh95@juanarbol@RaisinTen@PoojaDurgad