Skip to content

fs.mkdir: Add explicit note about undefined path when recursive - #37010

Closed
eps1lon wants to merge 2 commits into
nodejs:masterfrom
eps1lon:patch-1
Closed

fs.mkdir: Add explicit note about undefined path when recursive#37010
eps1lon wants to merge 2 commits into
nodejs:masterfrom
eps1lon:patch-1

Conversation

@eps1lon

Copy link
Copy Markdown
Contributor

Came up when changing the TypeScript types in DefinitelyTyped/DefinitelyTyped#50721

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 20, 2021
Comment threaddoc/api/fs.md Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2021
jasnell pushed a commit that referenced this pull request Jan 23, 2021
PR-URL: #37010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in 432a571

@jasnelljasnell closed this Jan 23, 2021
@eps1lon
eps1lon deleted the patch-1 branch January 23, 2021 09:15
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #37010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eps1lon@jasnell@aduh95@nodejs-github-bot