Uh oh!
There was an error while loading. Please reload this page.
test: update to improve terminology - #37011
Conversation
mhdawson
commented
Jan 21, 2021
The change in |
mhdawson
commented
Jan 21, 2021
@joyeecheung can you confirm that in terms of excluding tests that fail there is no better way to handle excluding the tests than what I've done? |
@mhdawson You can use "skip" instead of "fail" if you don't need the test expectation to be changed once the failure is fixed. But using "fail" is OK as well, and it prompts people to update the expectation. |
mhdawson
commented
Jan 22, 2021
@joyeecheung thanks |
nodejs-github-bot
commented
Jan 24, 2021
mhdawson
commented
Jan 25, 2021
Issue already open for test which failed in CI #36867 |
nodejs-github-bot
commented
Jan 25, 2021
mhdawson
commented
Jan 25, 2021
Resume build to try to get to green: https://ci.nodejs.org/job/node-test-pull-request/35737/ |
nodejs-github-bot
commented
Jan 26, 2021
mhdawson
commented
Jan 26, 2021
One more attempt: https://ci.nodejs.org/job/node-test-pull-request/35760/ as there was another unrelated failure (build time out) |
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#37011 Reviewed-By: Milad Fa <mfarazma@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jan 27, 2021
Landed in 9603e4a |
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37011 Reviewed-By: Milad Fa <mfarazma@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152
Signed-off-by: Michael Dawson mdawson@devrus.com