Skip to content

test: process.nextTick for beforeExit case - #37012

Closed
ttzztztz wants to merge 6 commits into
nodejs:masterfrom
ttzztztz:test-process-beforeexit
Closed

test: process.nextTick for beforeExit case#37012
ttzztztz wants to merge 6 commits into
nodejs:masterfrom
ttzztztz:test-process-beforeexit

Conversation

@ttzztztz

@ttzztztzttzztztz commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

This is a test for test case test/parallel/test-process-beforeexit.js to test the behavior of process.nextTick with process.on('beforeExit', ()=>{}) event

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@FlarnaFlarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2021
juanarbol
juanarbol approved these changes Jan 21, 2021
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttzztztz Thank you! This is amazing.

lpinca
lpinca approved these changes Jan 22, 2021
View reviewed changes
Comment threadtest/parallel/test-process-beforeexit.js Outdated
@ttzztztz@lpinca
Update test/parallel/test-process-beforeexit.js
d057220
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Trott
Trott reviewed Jan 24, 2021
View reviewed changes
Comment threadtest/parallel/test-process-beforeexit.js
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott

Trott commented Jan 24, 2021

Copy link
Copy Markdown
Member

Welcome @ttzztztz and thanks for the pull request!

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95
aduh95 reviewed Jan 25, 2021
View reviewed changes
Comment threadtest/parallel/test-process-beforeexit.js Outdated
Comment threadtest/parallel/test-process-beforeexit.js Outdated
aduh95
aduh95 reviewed Jan 25, 2021
View reviewed changes
Comment threadtest/parallel/test-process-beforeexit.js Outdated
Comment threadtest/parallel/test-process-beforeexit.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35726/

jasnell pushed a commit that referenced this pull request Jan 25, 2021
@ttzztztz@jasnell
test: process.nextTick for before exit
1377163
PR-URL: #37012
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

Landed in 1377163

@jasnelljasnell closed this Jan 25, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
@ttzztztz@targos
test: process.nextTick for before exit
94204f7
PR-URL: #37012
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@ttzztztz@targos
test: process.nextTick for before exit
456fd75
PR-URL: #37012
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@juanarboljuanarboljuanarbol approved these changes
@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ttzztztz@nodejs-github-bot@Trott@jasnell@lpinca@aduh95@juanarbol@Flarna