Skip to content

doc: list Unsupported Directory Import resolve err - #37032

Closed
guybedford wants to merge 3 commits into
masterfrom
list-unsupported-dir-import
Closed

doc: list Unsupported Directory Import resolve err#37032
guybedford wants to merge 3 commits into
masterfrom
list-unsupported-dir-import

Conversation

@guybedford

Copy link
Copy Markdown
Contributor

This updates the documentation of the resolver specification to include the Unsupported Directory Import in ths list of errors provided at the top of the specification, to ensure this list remains exhaustive of all the errors that might be thrown by the resolver.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 23, 2021
@guybedford

Copy link
Copy Markdown
ContributorAuthor

@nodejs/modules

Comment threaddoc/api/esm.md Outdated

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with spelling fix.

Co-authored-by: Rich Trott <rtrott@gmail.com>
guybedford added a commit that referenced this pull request Jan 25, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@guybedford

Copy link
Copy Markdown
ContributorAuthor

Landed in efa6e1d.

@guybedford
guybedford deleted the list-unsupported-dir-import branch January 25, 2021 11:05
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@guybedford@Trott@lpinca@nodejs-github-bot