tools: enable object-curly-newline in ESLint rules - #37040

Merged

Trott merged 2 commits into

nodejs:masterfrom

Trott:object-curly-newline

Jan 27, 2021

Trott commented Jan 23, 2021

Member

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.

Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)

nodejs-github-bot added the lib / src label

mscdex reviewed

View reviewed changes

doc/api/http2.md Outdated

mscdex reviewed

View reviewed changes

lib/internal/http2/core.js Outdated

aduh95 reviewed

View reviewed changes

test/parallel/test-inspector-esm.js Outdated

ExE-Boss reviewed

View reviewed changes

doc/api/http2.md Outdated

lib/internal/encoding.js Outdated

lib/internal/http2/core.js Outdated

test/node-api/test_threadsafe_function/test.js Outdated

test/parallel/test-http2-max-settings.js Outdated

test/parallel/test-webcrypto-sign-verify-rsa.js Outdated

test/parallel/test-webcrypto-sign-verify-rsa.js Outdated

test/parallel/test-webcrypto-wrap-unwrap.js Outdated

test/sequential/test-inspector.js Outdated

test/sequential/test-stream2-stderr-sync.js Outdated

Trott force-pushed the object-curly-newline branch 2 times, most recently from 8f009db to 79a6948Compare

January 25, 2021 22:29

Trott commented Jan 25, 2021

MemberAuthor

OK, I think I've added all the suggestions I agree with. Can still be persuaded on the other ones, but for now, PTAL?

targos approved these changes

View reviewed changes

aduh95 approved these changes

View reviewed changes

nodejs-github-bot commented Jan 26, 2021

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35749/

nodejs-github-bot commented Jan 26, 2021

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35759/

Trott added 2 commits

January 26, 2021 16:49

test,doc,lib: adjust object literal newlines for lint rule

996b85b

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

tools: enable object-curly-newline in ESLint rules

3e54870

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: nodejs#37028 (review)
PR-URL: nodejs#37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott force-pushed the object-curly-newline branch from 79a6948 to 3e54870Compare

January 27, 2021 00:50

Trott commented Jan 27, 2021

MemberAuthor

Landed in c5f3565...3e54870

Trott merged commit 3e54870 into nodejs:master

targos pushed a commit that referenced this pull request

test,doc,lib: adjust object literal newlines for lint rule

9c69ca5

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

tools: enable object-curly-newline in ESLint rules

d2d6121

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request

v15.8.0 release proposal #37183

Merged

targos added backport-blocked-v14.x and removed backport-blocked-v14.x labels

targos pushed a commit that referenced this pull request

test,doc,lib: adjust object literal newlines for lint rule

c9c6ed4

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

tools: enable object-curly-newline in ESLint rules

2a8db68

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

test,doc,lib: adjust object literal newlines for lint rule

3bb1c71

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

tools: enable object-curly-newline in ESLint rules

85d0442

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

test,doc,lib: adjust object literal newlines for lint rule

dc9c518

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

tools: enable object-curly-newline in ESLint rules

cbced2f

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request

v14.17.1 release proposal #38948

Merged

targos pushed a commit that referenced this pull request

test,doc,lib: adjust object literal newlines for lint rule

294b3e6

Before enabling object-curly-newline for our ESLint rules, adjust files
to comply with it.
Refs: https://eslint.org/docs/rules/object-curly-newline
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request

tools: enable object-curly-newline in ESLint rules

f868fac

I saw a PR review comment about newlines in desructured
assignments, and this would be the rule to enforce these kinds of nits.
Start by just enabling the rule. We can incrementally adjust it to be
more strict.
Refs: https://eslint.org/docs/rules/object-curly-newline
Refs: #37028 (review)
PR-URL: #37040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott deleted the object-curly-newline branch

September 25, 2022 17:04

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels