lib: fix WebIDL object and dictionary type conversion

[ExE-Boss]

The WebIDLobject, record<K, V>, and Dictionary type conversion algorithm implicitly allows Arrays and Functions:

• https://heycam.github.io/webidl/#es-object
• https://heycam.github.io/webidl/#es-record
• https://heycam.github.io/webidl/#es-dictionary

---

This is also necessary to prevent #37028 from being a breaking change.

[jasnell]

For performance reasons, It's likely better to introduce a separate validator function for this.

[aduh95]

So, should we run a benchmark CI for this, and which one?

[joyeecheung]

So, should we run a benchmark CI for this, and which one?

I think the benchmark/events/eventtarget.js is one you are looking for?

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/928/ (queued)

[aduh95]

Benchmark results are OK:

 confidence improvement accuracy (*) (**) (***)
events/eventtarget.jslisteners=10 n=1000000 -1.05 % ±4.82% ±6.42% ±8.37%
events/eventtarget.jslisteners=1 n=1000000 -1.17 % ±2.20% ±2.93% ±3.83%
events/eventtarget.jslisteners=5 n=1000000 0.38 % ±4.03% ±5.40% ±7.11%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 3 comparisons, you can thus
expect the following amount of false-positive results:
0.15 false positives, when considering a 5% risk acceptance (*, **, ***),
0.03 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)

[aduh95]

Shouldn't you pass nullable: true instead of having a if (options !== null)?

[ExE-Boss]

Right, this became possible when #35806 made options default to null.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35958/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35959/

[ExE-Boss]

The PR labels should probably include the events label or the eventtarget label.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36010/

[Trott]

Landed in beee538