Skip to content

crypto: fix encrypted private -> public import - #37056

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-fix-createpublickey-with-passphrase
Closed

crypto: fix encrypted private -> public import#37056
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:crypto-fix-createpublickey-with-passphrase

Conversation

@tniessen

@tniessentniessen commented Jan 25, 2021

Copy link
Copy Markdown
Member

This patch fixes the added test case. There is no reason for createPublicKey to not allow importing encrypted private keys. With this patch, the behavior matches the documentation.

@tniessentniessen added the crypto Issues and PRs related to the crypto subsystem. label Jan 25, 2021
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 25, 2021
@tniessen

tniessen commented Jan 25, 2021

Copy link
Copy Markdown
MemberAuthor

I personally consider the previous behavior a bug, so I am not labeling this as semver-minor.

@jasnell

jasnell commented Jan 25, 2021

Copy link
Copy Markdown
Member

As far as I can tell this is new functionality? This should likely be semver-minor.

addaleax
addaleax approved these changes Jan 25, 2021
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver-patch sounds good to me for this

@tniessen

tniessen commented Jan 25, 2021

Copy link
Copy Markdown
MemberAuthor

@jasnell That depends on whether we consider the documented behavior or the actual behavior. The documentation says:

Because public keys can be derived from private keys, a private key may be passed instead of a public key. In that case, this function behaves as if crypto.createPrivateKey() had been called

Since, unlike createPrivateKey, createPublicKey ignored the passphrase parameter, this was not an accurate description of the actual behavior. Therefore, I'd consider this a bug fix.

On the other hand, if we ignore the documentation, then this is indeed a new feature.

panva
panva approved these changes Jan 25, 2021
View reviewed changes

@panvapanva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver-patch seems appropriate

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35729/

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2021
tniessen added a commit that referenced this pull request Jan 27, 2021
@tniessen
crypto: fix encrypted private -> public import
c9992a0
PR-URL: #37056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen

tniessen commented Jan 27, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in c9992a0, thanks for reviewing.

@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2021
@tniessen
tniessen deleted the crypto-fix-createpublickey-with-passphrase branch January 27, 2021 14:43
targos pushed a commit that referenced this pull request Feb 2, 2021
@tniessen@targos
crypto: fix encrypted private -> public import
c4193ba
PR-URL: #37056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Feb 2, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen@jasnell@nodejs-github-bot@panva@addaleax@lpinca@cjihrig@targos