Skip to content

[15.x] Revert "stream: fix .end() error propagation" - #37060

Closed
mcollina wants to merge 1 commit into
nodejs:v15.x-stagingfrom
mcollina:revert-36817-v15
Closed

[15.x] Revert "stream: fix .end() error propagation"#37060
mcollina wants to merge 1 commit into
nodejs:v15.x-stagingfrom
mcollina:revert-36817-v15

Conversation

@mcollina

@mcollinamcollina commented Jan 25, 2021

Copy link
Copy Markdown
Member

This reverts commit 4c819d6.

Fixes#37027

@mcollina

mcollina commented Jan 25, 2021

Copy link
Copy Markdown
MemberAuthor

cc @lpinca@danielleadams

@mcollina
mcollina requested review from dnlup and ronagJanuary 25, 2021 08:34
@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2021•
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35722/ ✅

@Trott

Trott commented Jan 31, 2021

Copy link
Copy Markdown
Member

We should probably add a test for #37027. (Doesn't have to be here/now, though.)

@Trott

Trott commented Jan 31, 2021

Copy link
Copy Markdown
Member

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

@ronag

ronag commented Jan 31, 2021

Copy link
Copy Markdown
Member

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

Revert on 15 leave on master

@jasnelljasnell changed the title Revert "stream: fix .end() error propagation"[15.x] Revert "stream: fix .end() error propagation"Feb 1, 2021
@danielleadams

danielleadams commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Landed in d2a487e

danielleadams pushed a commit that referenced this pull request Feb 15, 2021
@mcollina@danielleadams
Revert "stream: fix .end() error propagation"
d2a487e
This reverts commit 4c819d6.
PR-URL: #37060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
@lpincalpinca mentioned this pull request Mar 5, 2021
Closed
@mcollina
mcollina deleted the revert-36817-v15 branch March 5, 2021 10:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@ronagronagronag approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
+2 more reviewers
@danielleadamsdanielleadamsdanielleadams approved these changes
@dnlupdnlupdnlup approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@nodejs-github-bot@Trott@ronag@danielleadams@lpinca@BethGriggs@dnlup