Skip to content

util: fix infinite recursion during inspection - #37079

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix/37054
Closed

util: fix infinite recursion during inspection#37079
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix/37054

Conversation

@BridgeAR

@BridgeARBridgeAR commented Jan 26, 2021•
edited
Loading

Copy link
Copy Markdown
Member
doc: fix outdated util inspect documentation and layout example
The documentation and layout example was not up to date with the
latest changes.

util: fix infinite recursion during inspection
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.

Fixes: #37054

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 26, 2021
@BridgeARBridgeAR added the needs-ci PRs that need a full CI run. label Jan 26, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@LxxyxLxxyx removed the needs-ci PRs that need a full CI run. label Jan 27, 2021
aduh95
aduh95 reviewed Jan 29, 2021
View reviewed changes
Comment threadlib/internal/util/inspect.js Outdated
Comment threadlib/internal/util/inspect.js Outdated
Trott
Trott reviewed Jan 31, 2021
View reviewed changes
Comment threaddoc/api/util.md Outdated
Trott
Trott approved these changes Jan 31, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @aduh95's nits and my question about the doc sample code sorted.

@BridgeAR

BridgeAR commented Mar 19, 2021

Copy link
Copy Markdown
MemberAuthor

PTAL

@BridgeAR
util: fix infinite recursion during inspection
486f8b8
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
doc: fix outdated util inspect documentation and layout example
7440350
The documentation and layout example was not up to date with the
latest changes.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
BridgeAR requested review from Trott and aduh95March 22, 2021 00:39
aduh95
aduh95 approved these changes Mar 22, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@antsmartianantsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2021•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37845/ 💚

@jasnell

jasnell commented Apr 30, 2021

Copy link
Copy Markdown
Member

Landed in 3c6ff9e...5bfb6f0

@jasnelljasnell closed this Apr 30, 2021
jasnell pushed a commit that referenced this pull request Apr 30, 2021
@BridgeAR@jasnell
util: fix infinite recursion during inspection
942b76d
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #37079Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 30, 2021
@BridgeAR@jasnell
doc: fix outdated util inspect documentation and layout example
5bfb6f0
The documentation and layout example was not up to date with the
latest changes.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #37079Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 3, 2021
@BridgeAR@targos
util: fix infinite recursion during inspection
ec5b06e
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #37079Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 3, 2021
@BridgeAR@targos
doc: fix outdated util inspect documentation and layout example
9258604
The documentation and layout example was not up to date with the
latest changes.
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #37079Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@aduh95aduh95aduh95 approved these changes
@trivikrtrivikrtrivikr approved these changes
@juanarboljuanarboljuanarbol approved these changes
+1 more reviewer
@antsmartianantsmartianantsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

specific scenario causes infinite recursion in util.inspect (max stack size exceeded)

10 participants

@BridgeAR@nodejs-github-bot@jasnell@Trott@antsmartian@aduh95@trivikr@juanarbol@targos@Lxxyx