Uh oh!
There was an error while loading. Please reload this page.
doc,test: fix prime generation description - #37085
Merged
aduh95 merged 1 commit intoFeb 1, 2021
Merged
Conversation
juanarbol
approved these changes
Jan 26, 2021
jasnell
approved these changes
Jan 26, 2021
This comment has been minimized.
This comment has been minimized.
tniessen
commented
Jan 27, 2021
MemberAuthor
@richardlau I am having trouble finding the OpenSSL version that |
Trott
approved these changes
Jan 31, 2021
This comment has been minimized.
This comment has been minimized.
tniessenforce-pushed
the
doc-test-fix-prime-description-add-rem
branch
from
January 31, 2021 15:46
c21fc8d to
6b6cdcfCompare
This comment has been minimized.
This comment has been minimized.
tniessen
commented
Jan 31, 2021
MemberAuthor
Found it, it's 1.1.1c, which has a few quirks when it comes to prime number generation. Disabled the test for those versions. PTAL assuming CI passes. |
tniessenforce-pushed
the
doc-test-fix-prime-description-add-rem
branch
from
January 31, 2021 16:52
6b6cdcf to
0fdea88Comparenodejs-github-bot
commented
Jan 31, 2021
Collaborator
The previous description incorrectly explained the behavior of options.add and options.rem for primes that are not safe. PR-URL: nodejs#37085 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95force-pushed
the
doc-test-fix-prime-description-add-rem
branch
from
February 1, 2021 15:15
0fdea88 to
814f971Compareaduh95
commented
Feb 1, 2021
Contributor
Landed in 814f971 |
targos pushed a commit
that referenced
this pull request
Feb 2, 2021
The previous description incorrectly explained the behavior of options.add and options.rem for primes that are not safe. PR-URL: #37085 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jan 13, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous description incorrectly explained the behavior of
options.addandoptions.remfor primes that are not safe.