Uh oh!
There was an error while loading. Please reload this page.
readline: replace _questionCancel with a symbol - #37094
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
This commit avoids exposing a new underscored property on readline Interface instances.
Lxxyx
approved these changes
Jan 27, 2021
nodejs-github-bot
commented
Jan 27, 2021
Collaborator
lpinca
approved these changes
Jan 27, 2021
targos
approved these changes
Jan 27, 2021
jasnell
approved these changes
Jan 27, 2021
Lxxyx pushed a commit
that referenced
this pull request
Jan 29, 2021
This commit avoids exposing a new underscored property on readline Interface instances. PR-URL: #37094 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Lxxyx
commented
Jan 29, 2021
Member
Landed in fec093b |
targos pushed a commit
that referenced
this pull request
Feb 2, 2021
This commit avoids exposing a new underscored property on readline Interface instances. PR-URL: #37094 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit avoids exposing a new underscored property on
readline Interface instances.